[GitHub] [pinot] KKcorps commented on a diff in pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10598: URL: https://github.com/apache/pinot/pull/10598#discussion_r1176031173 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GreatestTransformFunction.java: ## @@ -44,6 +47,35 @@ public int[] transformToIntValuesSV(

[GitHub] [pinot] KKcorps commented on a diff in pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10598: URL: https://github.com/apache/pinot/pull/10598#discussion_r1176029013 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/DateTimeConversionTransformFunction.java: ## @@ -106,8 +107,8 @@ public void init(List arg

[GitHub] [pinot] KKcorps commented on a diff in pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10598: URL: https://github.com/apache/pinot/pull/10598#discussion_r1176027992 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CoalesceTransformFunction.java: ## @@ -399,4 +390,22 @@ public String[] transformToStringV

[GitHub] [pinot] KKcorps commented on a diff in pull request #10598: [feature] [null support # 9] Support null in time related transform functions.

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10598: URL: https://github.com/apache/pinot/pull/10598#discussion_r1176027992 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CoalesceTransformFunction.java: ## @@ -399,4 +390,22 @@ public String[] transformToStringV

[GitHub] [pinot] KKcorps commented on a diff in pull request #10594: [feature] [null support # 8] Support null in all null related transform functions

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10594: URL: https://github.com/apache/pinot/pull/10594#discussion_r1176019887 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java: ## @@ -241,226 +266,768 @@ public TransformResultMetadata getR

[GitHub] [pinot] KKcorps commented on a diff in pull request #10594: [feature] [null support # 8] Support null in all null related transform functions

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10594: URL: https://github.com/apache/pinot/pull/10594#discussion_r1176019887 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java: ## @@ -241,226 +266,768 @@ public TransformResultMetadata getR

[GitHub] [pinot] KKcorps commented on a diff in pull request #10594: [feature] [null support # 8] Support null in all null related transform functions

2023-04-24 Thread via GitHub
KKcorps commented on code in PR #10594: URL: https://github.com/apache/pinot/pull/10594#discussion_r1176017230 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java: ## @@ -241,226 +266,768 @@ public TransformResultMetadata getR

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10683: Refine the return error code of query killing

2023-04-24 Thread via GitHub
jasperjiaguo commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1175967903 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -816,6 +816,9 @@ public static class Accounting { public static final Stri

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10683: Refine the return error code of query killing

2023-04-24 Thread via GitHub
jasperjiaguo commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1175967903 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -816,6 +816,9 @@ public static class Accounting { public static final Stri

[pinot] branch master updated (a130cb2b1e -> 96d34fd280)

2023-04-24 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a130cb2b1e [multistage] Modify empty LogicalProject for window functions to have a literal (#10635) add 96d34

[GitHub] [pinot] siddharthteotia merged pull request #10684: [multistage] Add some additional planner tests for ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia merged PR #10684: URL: https://github.com/apache/pinot/pull/10684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10684: [multistage] Add some additional planner tests for ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10684: URL: https://github.com/apache/pinot/pull/10684#discussion_r1175934088 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1278,6 +1278,54 @@ "\n" ] }, + { +"de

[GitHub] [pinot] codecov-commenter commented on pull request #10684: [multistage] Add some additional planner tests for ROW_NUMBER() window function

2023-04-24 Thread via GitHub
codecov-commenter commented on PR #10684: URL: https://github.com/apache/pinot/pull/10684#issuecomment-1521042266 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175933041 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -843,6 +1015,23 @@ "\n" ] }, + { +"des

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175933041 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -843,6 +1015,23 @@ "\n" ] }, + { +"des

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10683: Refine the return error code of query killing

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10683: URL: https://github.com/apache/pinot/pull/10683#discussion_r1175931547 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -816,6 +816,9 @@ public static class Accounting { public static final S

[GitHub] [pinot] codecov-commenter commented on pull request #10683: Refine the return error code of query killing

2023-04-24 Thread via GitHub
codecov-commenter commented on PR #10683: URL: https://github.com/apache/pinot/pull/10683#issuecomment-1521027482 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] codecov-commenter commented on pull request #10660: Separate and parallelize BloomFilter based semgment pruner

2023-04-24 Thread via GitHub
codecov-commenter commented on PR #10660: URL: https://github.com/apache/pinot/pull/10660#issuecomment-1521017224 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10660?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] somandal commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175906073 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1107,6 +1323,22 @@ "\n" ] Review Comment: done as part of ht

[GitHub] [pinot] somandal commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175905988 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -52,8 +53,10 @@ * columns and in addition will add t

[GitHub] [pinot] somandal commented on pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on PR #10587: URL: https://github.com/apache/pinot/pull/10587#issuecomment-1520996294 @siddharthteotia opened a PR to address comments: https://github.com/apache/pinot/pull/10684 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pinot] somandal opened a new pull request, #10684: [multistage] Add some additional planner tests for ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal opened a new pull request, #10684: URL: https://github.com/apache/pinot/pull/10684 This PR address the review comments on the `ROW_NUMBER()` window functions PR: https://github.com/apache/pinot/pull/10587 cc @siddharthteotia @vvivekiyer @walterddr -- This is an automated

[GitHub] [pinot] jasperjiaguo opened a new pull request, #10683: Refine the return error code of query killing

2023-04-24 Thread via GitHub
jasperjiaguo opened a new pull request, #10683: URL: https://github.com/apache/pinot/pull/10683 Return 205 not 200 when the query is killed to distinguish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] somandal commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175902817 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1062,6 +1264,20 @@ "\n" ] }, + { +"descripti

[GitHub] [pinot] somandal opened a new issue, #10682: Investigate why some aliases are removed by Apache Calcite for window functions

2023-04-24 Thread via GitHub
somandal opened a new issue, #10682: URL: https://github.com/apache/pinot/issues/10682 For some of the window function queries the aliases are removed. Need to look into why. Opening this ticket to track this work. E.g. ``` "sql": "EXPLAIN PLAN FOR SELECT a.col1 AS

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10681: Re-implement mailbox

2023-04-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #10681: URL: https://github.com/apache/pinot/pull/10681 - Use `string` as the mailbox id - Use one single `MailboxService` implementation to handle both local and remote mails - Solve the dangling mailbox caused by late mails - If the mailbo

[GitHub] [pinot] somandal commented on issue #10658: [multistage] distinct/group by support on array(multi-value) column

2023-04-24 Thread via GitHub
somandal commented on issue #10658: URL: https://github.com/apache/pinot/issues/10658#issuecomment-1520941010 Thanks @vvivekiyer I'll take a look at this in more detail soon. Just wanted to bring up what we discussed offline: > Do not introduce an ARRAY datatype. But equate/evolve our

[GitHub] [pinot] lakshmanan-v commented on a diff in pull request #10638: Add request timeout to java client

2023-04-24 Thread via GitHub
lakshmanan-v commented on code in PR #10638: URL: https://github.com/apache/pinot/pull/10638#discussion_r1175842921 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java: ## @@ -114,9 +131,14 @@ public JsonAsyncHttpPinotC

[GitHub] [pinot] travis-cook-sfdc opened a new issue, #10680: Pinot doesn't return most data in the `metadata` JSON Property when tables are created

2023-04-24 Thread via GitHub
travis-cook-sfdc opened a new issue, #10680: URL: https://github.com/apache/pinot/issues/10680 Submitting the following table config: ``` { "tableName": "test_table", "tableType": "OFFLINE", "tenants": { "broker": "DefaultTenant", "server": "DefaultTenan

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [multistage] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175825406 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/serde/QueryPlanSerDeUtils.java: ## @@ -45,108 +43,100 @@ private QueryPlanSerDeUtils() {

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [multistage] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175825225 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/OperatorUtils.java: ## @@ -68,7 +68,7 @@ public static String canonicalizeFunctionN

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [multistage] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175824931 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ## @@ -290,10 +284,8 @@ private InstanceResponseBlock processServerQuery(Server

[GitHub] [pinot] raghavgautam commented on a diff in pull request #10639: changing the dedup store to become pluggable

2023-04-24 Thread via GitHub
raghavgautam commented on code in PR #10639: URL: https://github.com/apache/pinot/pull/10639#discussion_r1175797401 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentHashMapKeyValueStore.java: ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] raghavgautam commented on a diff in pull request #10639: changing the dedup store to become pluggable

2023-04-24 Thread via GitHub
raghavgautam commented on code in PR #10639: URL: https://github.com/apache/pinot/pull/10639#discussion_r1175796693 ## pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/dedup/LocalKeyValueStore.java: ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (A

[pinot] branch master updated: [multistage] Modify empty LogicalProject for window functions to have a literal (#10635)

2023-04-24 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a130cb2b1e [multistage] Modify empty LogicalP

[GitHub] [pinot] siddharthteotia merged pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia merged PR #10635: URL: https://github.com/apache/pinot/pull/10635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] atris commented on issue #10609: Support for case-sensitive like in Pinot

2023-04-24 Thread via GitHub
atris commented on issue #10609: URL: https://github.com/apache/pinot/issues/10609#issuecomment-1520626208 > @atris > > Asked ChatGPT on this > > > The SQL Standard defines the LIKE operator to be case insensitive > > and it says: > > ``` > According to the SQL-

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10639: changing the dedup store to become pluggable

2023-04-24 Thread via GitHub
ankitsultana commented on code in PR #10639: URL: https://github.com/apache/pinot/pull/10639#discussion_r1175605176 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentHashMapKeyValueStore.java: ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] jtao15 opened a new pull request, #10679: Allow custom lineage update and gc

2023-04-24 Thread via GitHub
jtao15 opened a new pull request, #10679: URL: https://github.com/apache/pinot/pull/10679 This pr add LineageManager which: 1. allow custom lineage updates before committing any lineage change 2. allow custom lineage gc -- This is an automated message from the Apache Git Service.

[GitHub] [pinot] codecov-commenter commented on pull request #10678: Add server metrics to capture gRPC activity

2023-04-24 Thread via GitHub
codecov-commenter commented on PR #10678: URL: https://github.com/apache/pinot/pull/10678#issuecomment-1520557692 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] klsince commented on a diff in pull request #10660: [WIP] parallelize bf based pruner

2023-04-24 Thread via GitHub
klsince commented on code in PR #10660: URL: https://github.com/apache/pinot/pull/10660#discussion_r1175579771 ## pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java: ## @@ -94,60 +103,159 @@ public List prune(List segments, QueryContext qu

[GitHub] [pinot] tibrewalpratik17 commented on issue #10609: Support for case-sensitive like in Pinot

2023-04-24 Thread via GitHub
tibrewalpratik17 commented on issue #10609: URL: https://github.com/apache/pinot/issues/10609#issuecomment-1520545910 @atris Asked ChatGPT on this > The SQL Standard defines the LIKE operator to be case insensitive and it says: ``` According to the SQL-92 standard, col

[GitHub] [pinot] vvivekiyer commented on issue #10658: [multistage] distinct/group by support on array(multi-value) column

2023-04-24 Thread via GitHub
vvivekiyer commented on issue #10658: URL: https://github.com/apache/pinot/issues/10658#issuecomment-1520518081 I have a [draft implementation for SUM_MV here](https://github.com/apache/pinot/compare/master...vvivekiyer:pinot:multistage_mv). I can improve on it and add support for all other

[GitHub] [pinot] cbalci opened a new pull request, #10678: Add server metrics to capture gRPC activity

2023-04-24 Thread via GitHub
cbalci opened a new pull request, #10678: URL: https://github.com/apache/pinot/pull/10678 Can be used to: - distinguish gRPC queries from Netty based ones - track migrations from HTTP to gRPC - etc. `observability` -- This is an automated message from the Apache Git Service

[GitHub] [pinot] somandal commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175537604 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] somandal commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175537206 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -14,6 +14,33 @@ "\n" ] }, + { +"description":

[GitHub] [pinot] somandal commented on pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on PR #10635: URL: https://github.com/apache/pinot/pull/10635#issuecomment-1520491742 > @somandal - can you rebase please ? @siddharthteotia I've rebased, can you take a look when you get a chance? Thanks! -- This is an automated message from the Apache Git Servi

[GitHub] [pinot] somandal commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175535058 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -843,6 +1015,23 @@ "\n" ] }, + { +"descriptio

[GitHub] [pinot] somandal commented on pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
somandal commented on PR #10587: URL: https://github.com/apache/pinot/pull/10587#issuecomment-1520483734 @siddharthteotia thanks for the review! I'll address these comments as a separate PR (don't want to mix this into the other PR I have open to fix the empty LogicalProject issue as it'll

[GitHub] [pinot] somandal commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175526221 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175492784 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByO

[GitHub] [pinot] siddharthteotia commented on pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on PR #10635: URL: https://github.com/apache/pinot/pull/10635#issuecomment-1520435852 @somandal - can you rebase please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175492784 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByO

[GitHub] [pinot] somandal commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175457046 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175446362 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java: ## @@ -143,10 +138,9 @@ public void testWorkerAcceptsWorkerRequestCorrect(St

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175431085 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1107,6 +1323,22 @@ "\n" ] Review Comment: Looks good.

[pinot] branch master updated: [multistage] Add support for the ranking ROW_NUMBER() window function (#10587)

2023-04-24 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4914947263 [multistage] Add support for the r

[GitHub] [pinot] siddharthteotia merged pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia merged PR #10587: URL: https://github.com/apache/pinot/pull/10587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175416049 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -52,8 +53,10 @@ * columns and in addition wil

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175410498 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -205,18 +223,42 @@ private boolean isPartition

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175402601 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -646,6 +803,21 @@ "\n" ] }, + { +"desc

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175400678 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -646,6 +803,21 @@ "\n" ] }, + { +"desc

[GitHub] [pinot] somandal commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
somandal commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175388766 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -14,6 +14,33 @@ "\n" ] }, + { +"description":

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175387525 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -843,6 +1015,23 @@ "\n" ] }, + { +"des

[GitHub] [pinot] chrishanKH commented on issue #10654: PinotFS for scheme: s3 has not been initialized

2023-04-24 Thread via GitHub
chrishanKH commented on issue #10654: URL: https://github.com/apache/pinot/issues/10654#issuecomment-1520290411 I believe the [config map](https://github.com/apache/pinot/blob/master/kubernetes/helm/pinot/templates/controller/configmap.yaml) should be updated to include the S3 related confi

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175382902 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java: ## @@ -143,10 +138,9 @@ public void testWorkerAcceptsWorkerRequestCorrect(St

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175381142 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1049,6 +1238,19 @@ "\n" ] }, + { +"de

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175381142 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1049,6 +1238,19 @@ "\n" ] }, + { +"de

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175381142 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1049,6 +1238,19 @@ "\n" ] }, + { +"de

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175381081 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxIdentifier.java: ## @@ -37,12 +37,12 @@ public interface MailboxIdentifier { /** * @

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175379827 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerMetadata.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175377455 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/QueryPlan.java: ## @@ -39,13 +44,15 @@ public class QueryPlan { private final List> _queryResu

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175376299 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/QueryPlan.java: ## @@ -39,13 +44,15 @@ public class QueryPlan { private final List> _queryResu

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10587: [multistage] Add support for the ranking ROW_NUMBER() window function

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10587: URL: https://github.com/apache/pinot/pull/10587#discussion_r1175375787 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -1062,6 +1264,20 @@ "\n" ] }, + { +"de

[GitHub] [pinot] walterddr commented on a diff in pull request #10673: [draft] clean up stage metadata and mailbox usage on instance/server

2023-04-24 Thread via GitHub
walterddr commented on code in PR #10673: URL: https://github.com/apache/pinot/pull/10673#discussion_r1175372855 ## pinot-common/src/main/proto/worker.proto: ## @@ -72,21 +72,17 @@ message StagePlan { int32 stageId = 1; string instanceId = 2; StageNode stageRoot = 3; -

[GitHub] [pinot] somandal commented on issue #10677: [multistage] Window Function Error with aggregation function

2023-04-24 Thread via GitHub
somandal commented on issue #10677: URL: https://github.com/apache/pinot/issues/10677#issuecomment-1520243457 I can take a look at this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] siddharthteotia commented on issue #10677: [multistage] Window Function Error with aggregation function

2023-04-24 Thread via GitHub
siddharthteotia commented on issue #10677: URL: https://github.com/apache/pinot/issues/10677#issuecomment-1520230332 cc @somandal - please comment here once for me to assign to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] siddharthteotia opened a new issue, #10677: [multistage] Window Function Error with aggregation function

2023-04-24 Thread via GitHub
siddharthteotia opened a new issue, #10677: URL: https://github.com/apache/pinot/issues/10677 Creating this to track an issue received in user feedback. Yet to take a look Query ``` SET useMultistageEngine=true; select orderID, max(cast(updatedTime as DOUBLE)) over(partiti

[GitHub] [pinot] siddharthteotia opened a new issue, #10676: [multistage] NOT IN subquery not working

2023-04-24 Thread via GitHub
siddharthteotia opened a new issue, #10676: URL: https://github.com/apache/pinot/issues/10676 Creating this to track issue received in user feedback. Yet to take a look NOT IN subquery not working Query: ``` SET useMultistageEngine=true; select DISTINCT(orderID) fro

[GitHub] [pinot] siddharthteotia commented on pull request #10646: Changing LIKE behaviour to case-sensitive and adding support for ILIKE

2023-04-24 Thread via GitHub
siddharthteotia commented on PR #10646: URL: https://github.com/apache/pinot/pull/10646#issuecomment-1520192324 I will take a look at this and corresponding issue discussion today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175306947 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByO

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175293292 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -14,6 +14,33 @@ "\n" ] }, + { +"descri

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175282591 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -171,4 +195,59 @@ private boolean isPartitionByO

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175270368 ## pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json: ## @@ -14,6 +14,33 @@ "\n" ] }, + { +"descri

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175266113 ## pinot-query-runtime/src/test/resources/queries/WindowFunctions.json: ## @@ -51,6 +51,50 @@ [768] ] }, + { +"descripti

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10635: [multistage] Modify empty LogicalProject for window functions to have a literal

2023-04-24 Thread via GitHub
siddharthteotia commented on code in PR #10635: URL: https://github.com/apache/pinot/pull/10635#discussion_r1175265477 ## pinot-query-runtime/src/test/resources/queries/WindowFunctions.json: ## @@ -51,6 +51,50 @@ [768] ] }, + { +"descripti

[GitHub] [pinot] atris commented on issue #10609: Support for case-sensitive like in Pinot

2023-04-24 Thread via GitHub
atris commented on issue #10609: URL: https://github.com/apache/pinot/issues/10609#issuecomment-1519868779 > @Jackie-Jiang @walterddr : just fyi, the behavior of like is not compliant with Postgres. LIKE is case sensitive there but in Pinot it is case insensitive. Postgres's ILIKE is

[GitHub] [pinot] tibrewalpratik17 commented on issue #10609: Support for case-sensitive like in Pinot

2023-04-24 Thread via GitHub
tibrewalpratik17 commented on issue #10609: URL: https://github.com/apache/pinot/issues/10609#issuecomment-1519669026 cc @atris -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pinot] gortiz commented on issue #10675: Failures in RealtimeQuickStart when indexes are changed

2023-04-24 Thread via GitHub
gortiz commented on issue #10675: URL: https://github.com/apache/pinot/issues/10675#issuecomment-1519586705 I also tried to remove/create an inverted index in `airlineStats`, specifically in the Origin column, and it doesn't seem to break anything, so maybe the problem is only related to th

[GitHub] [pinot] gortiz opened a new issue, #10675: Failures in RealtimeQuickStart when indexes are changed

2023-04-24 Thread via GitHub
gortiz opened a new issue, #10675: URL: https://github.com/apache/pinot/issues/10675 RealtimeQuickStart seems to fail when indexes are changed (either created, updated or removed). In order to reproduce it: * Start RealtimeQuickStart (or RealtimeQuickStartWithMinion, both seem to

[GitHub] [pinot] codecov-commenter commented on pull request #10674: Change getPrettyName() to default to getId()

2023-04-24 Thread via GitHub
codecov-commenter commented on PR #10674: URL: https://github.com/apache/pinot/pull/10674#issuecomment-1519538636 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] KKcorps commented on pull request #10625: Make table deletion idempotent

2023-04-24 Thread via GitHub
KKcorps commented on PR #10625: URL: https://github.com/apache/pinot/pull/10625#issuecomment-1519516805 I am already storing progress in the ZK. That's how the deleteStatusAPI works. Without the message thought how are we supposed to return API response immediately? Other jobs are dealing w