walterddr commented on code in PR #10673:
URL: https://github.com/apache/pinot/pull/10673#discussion_r1175446362
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java:
##########
@@ -143,10 +138,9 @@ public void testWorkerAcceptsWorkerRequestCorrect(String
sql)
}
}
- private static boolean isMetadataMapsEqual(StageMetadata left, StageMetadata
right) {
- return left.getServerInstances().equals(right.getServerInstances())
- &&
left.getServerInstanceToSegmentsMap().equals(right.getServerInstanceToSegmentsMap())
- && left.getScannedTables().equals(right.getScannedTables());
+ private boolean isMetadataMapsEqual(int stageId, DispatchablePlanMetadata
stageMetadata,
+ Map<Integer, WorkerMetadata> metadataMap) {
+ return true;
Review Comment:
actually take that back. i can directly compare distributed plan worker
metadata with query plan one instead of having to compare dispatchable plan
metadata.
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/service/QueryServerTest.java:
##########
@@ -143,10 +138,9 @@ public void testWorkerAcceptsWorkerRequestCorrect(String
sql)
}
}
- private static boolean isMetadataMapsEqual(StageMetadata left, StageMetadata
right) {
- return left.getServerInstances().equals(right.getServerInstances())
- &&
left.getServerInstanceToSegmentsMap().equals(right.getServerInstanceToSegmentsMap())
- && left.getScannedTables().equals(right.getScannedTables());
+ private boolean isMetadataMapsEqual(int stageId, DispatchablePlanMetadata
stageMetadata,
+ Map<Integer, WorkerMetadata> metadataMap) {
+ return true;
Review Comment:
actually take that back. i can directly compare distributed plan worker
metadata with query plan one instead of having to compare dispatchable plan
metadata. will update in next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
