walterddr commented on code in PR #10673:
URL: https://github.com/apache/pinot/pull/10673#discussion_r1175377455


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/QueryPlan.java:
##########
@@ -39,13 +44,15 @@
 public class QueryPlan {
   private final List<Pair<Integer, String>> _queryResultFields;
   private final Map<Integer, StageNode> _queryStageMap;
-  private final Map<Integer, StageMetadata> _stageMetadataMap;
+  private final Map<Integer, WorkerMetadata> _stageMetadataMap;
+  private final Map<Integer, DispatchablePlanMetadata> 
_dispatchablePlanMetadataMap;
 
   public QueryPlan(List<Pair<Integer, String>> fields, Map<Integer, StageNode> 
queryStageMap,
-      Map<Integer, StageMetadata> stageMetadataMap) {
+      Map<Integer, DispatchablePlanMetadata> dispatchablePlanMetadataMap) {
     _queryResultFields = fields;
     _queryStageMap = queryStageMap;
-    _stageMetadataMap = stageMetadataMap;
+    _dispatchablePlanMetadataMap = dispatchablePlanMetadataMap;

Review Comment:
   one can argue that the entire dispatchablePlanMetadataMap need not be 
stored. only the QueryServerInstance to workerId list is needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to