walterddr commented on code in PR #10673:
URL: https://github.com/apache/pinot/pull/10673#discussion_r1175376299
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/QueryPlan.java:
##########
@@ -39,13 +44,15 @@
public class QueryPlan {
private final List<Pair<Integer, String>> _queryResultFields;
private final Map<Integer, StageNode> _queryStageMap;
- private final Map<Integer, StageMetadata> _stageMetadataMap;
+ private final Map<Integer, WorkerMetadata> _stageMetadataMap;
+ private final Map<Integer, DispatchablePlanMetadata>
_dispatchablePlanMetadataMap;
Review Comment:
- 1st map is for distributedStagePlan. one can argue it doesn't need to be
materialized until distributeStagePlan is constructed
- 2nd map is for dispatcher only - to dispatch stage to physical server.
nit: rename _stageMetdataMap to _workerMetadataMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
