[GitHub] [pinot] codecov-commenter commented on pull request #10104: fix java doc in AbstractMetrics

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10104: URL: https://github.com/apache/pinot/pull/10104#issuecomment-1378363979 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10104?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] matthiasValuecloud commented on issue #9670: Working with new schema registry consuming serialized avro messages

2023-01-10 Thread GitBox
matthiasValuecloud commented on issue #9670: URL: https://github.com/apache/pinot/issues/9670#issuecomment-1378349677 Any news on that subject? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] matthiasValuecloud closed issue #9670: Working with new schema registry consuming serialized avro messages

2023-01-10 Thread GitBox
matthiasValuecloud closed issue #9670: Working with new schema registry consuming serialized avro messages URL: https://github.com/apache/pinot/issues/9670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10104: fix java doc in AbstractMetrics

2023-01-10 Thread GitBox
xiangfu0 commented on code in PR #10104: URL: https://github.com/apache/pinot/pull/10104#discussion_r101929 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName, fina

[GitHub] [pinot] KKcorps commented on a diff in pull request #10030: pinot-protobuf plugin generate descriptor using protobuf message java class name

2023-01-10 Thread GitBox
KKcorps commented on code in PR #10030: URL: https://github.com/apache/pinot/pull/10030#discussion_r102884 ## pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java: ## @@ -65,4 +75,114 @@ public static F

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10105: Use Cluster conf to enable/disable Groovy

2023-01-10 Thread GitBox
xiangfu0 commented on code in PR #10105: URL: https://github.com/apache/pinot/pull/10105#discussion_r1066651259 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -967,4 +969,18 @@ private long validateSegmentStateFo

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10104: fix java doc in AbstractMetrics

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10104: URL: https://github.com/apache/pinot/pull/10104#discussion_r1066649310 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName, fi

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10104: fix java doc in AbstractMetrics

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10104: URL: https://github.com/apache/pinot/pull/10104#discussion_r1066649310 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -707,15 +708,16 @@ public void removeTableGauge(final String tableName, fi

[GitHub] [pinot] KKcorps opened a new pull request, #10105: Use Cluster conf to enable/disable Groovy

2023-01-10 Thread GitBox
KKcorps opened a new pull request, #10105: URL: https://github.com/apache/pinot/pull/10105 Currently, enabling groovy configuration requires changing the controller configuration and then do a deployment to reflect that conf. With this change admins will be able to set this conf in the clus

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1066633703 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1066631552 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @

[GitHub] [pinot] saurabhd336 commented on pull request #10089: Reload conditional skip

2023-01-10 Thread GitBox
saurabhd336 commented on PR #10089: URL: https://github.com/apache/pinot/pull/10089#issuecomment-1378275497 @npawar @klsince -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] elonazoulay opened a new issue, #10103: Possible Race Condition with Consistent push clobbers segment lineage

2023-01-10 Thread GitBox
elonazoulay opened a new issue, #10103: URL: https://github.com/apache/pinot/issues/10103 If there is an empty table and multiple jobs run start/end replace segments in parallel, there appears to be a reproducible race condition where each job creates the segment lineage entry in zookeeper

[GitHub] [pinot] codecov-commenter commented on pull request #10098: Fix bug in colocated tenant creation

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10098: URL: https://github.com/apache/pinot/pull/10098#issuecomment-1378236711 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10098?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10088: Add controller API for force commit status

2023-01-10 Thread GitBox
saurabhd336 commented on code in PR #10088: URL: https://github.com/apache/pinot/pull/10088#discussion_r1066563178 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -384,7 +384,7 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => { s

[pinot] branch master updated: Prevent appending http headers when uploadSegmentMetadata is called in a loop (#10102)

2023-01-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8022c792f1 Prevent appending http headers when upl

[GitHub] [pinot] snleee merged pull request #10102: Prevent appending http headers when uploadSegmentMetadata is called i…

2023-01-10 Thread GitBox
snleee merged PR #10102: URL: https://github.com/apache/pinot/pull/10102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] codecov-commenter commented on pull request #10102: Prevent appending http headers when uploadSegmentMetadata is called i…

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10102: URL: https://github.com/apache/pinot/pull/10102#issuecomment-1378211012 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] elonazoulay closed issue #7545: Column alias with same name as column causes pinot to hang

2023-01-10 Thread GitBox
elonazoulay closed issue #7545: Column alias with same name as column causes pinot to hang URL: https://github.com/apache/pinot/issues/7545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pinot] elonazoulay commented on issue #7545: Column alias with same name as column causes pinot to hang

2023-01-10 Thread GitBox
elonazoulay commented on issue #7545: URL: https://github.com/apache/pinot/issues/7545#issuecomment-1378205425 Apologies for the delay. This is fixed! Thanks @SandishKumarHN , @Jackie-Jiang @xiangfu0 ! -- This is an automated message from the Apache Git Service. To respond to the message,

[pinot] branch master updated: fix a metric name composing issue (#10100)

2023-01-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c3c96adda1 fix a metric name composing issue (#101

[GitHub] [pinot] snleee merged pull request #10100: fix a metric name composing issue

2023-01-10 Thread GitBox
snleee merged PR #10100: URL: https://github.com/apache/pinot/pull/10100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] rajagopr opened a new pull request, #10102: Prevent appending http headers when uploadSegmentMetadata is called i…

2023-01-10 Thread GitBox
rajagopr opened a new pull request, #10102: URL: https://github.com/apache/pinot/pull/10102 Changes are to prevent appending the request http headers over and over when `segmentUriToTarPathMap` contains multiple entries. It results in the following exception. ``` org.apache.pinot.

[GitHub] [pinot] jugomezv opened a new pull request, #10101: Simplify delay tracking in ingestion delay metric code

2023-01-10 Thread GitBox
jugomezv opened a new pull request, #10101: URL: https://github.com/apache/pinot/pull/10101 Followup to address some open issues [PR9994](https://github.com/apache/pinot/pull/9994) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066500910 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseDistinctAggregateAggregationFunction.java: ## @@ -0,0 +1,504 @@ +/** + * Licensed to

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066500655 ## pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java: ## @@ -1680,6 +1680,16 @@ public void testSelectAggregate() { result4.add(new

[GitHub] [pinot] jugomezv commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

2023-01-10 Thread GitBox
jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1066499436 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java: ## @@ -0,0 +1,361 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] 61yao opened a new pull request, #10099: [multistage] [bugfix] Temp fix for grpc receiving buffer full issue

2023-01-10 Thread GitBox
61yao opened a new pull request, #10099: URL: https://github.com/apache/pinot/pull/10099 Make grpc receiving buffer unbounded so we don't drop data block. Add a debug logging so we can know the maximum buffer size we have reached. -- This is an automated message from the Apache Git

[pinot] branch master updated (b09e9e645f -> 2c798e7c42)

2023-01-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b09e9e645f evaluate EQ queries against range index when available (#10043) add 2c798e7c42 [Clean up] Remove the de

[GitHub] [pinot] snleee merged pull request #10084: [Clean up] Remove the deprecated RecordTransformer

2023-01-10 Thread GitBox
snleee merged PR #10084: URL: https://github.com/apache/pinot/pull/10084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10098: Fix bug in colocated tenant creation

2023-01-10 Thread GitBox
Jackie-Jiang opened a new pull request, #10098: URL: https://github.com/apache/pinot/pull/10098 Fix the IndexOutOfBoundException when untagged server count is the same as offline instances requested for colocated tenant creation -- This is an automated message from the Apache Git Service.

[GitHub] [pinot] somandal commented on a diff in pull request #9982: Reload the SegmentMetadata even for temporary forward index

2023-01-10 Thread GitBox
somandal commented on code in PR #9982: URL: https://github.com/apache/pinot/pull/9982#discussion_r1066467676 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseIndexHandler.java: ## @@ -41,13 +41,17 @@ public abstract class BaseIndexHa

[GitHub] [pinot] codecov-commenter commented on pull request #10092: Fixes filtered agg result column naming and filtered agg order-by compat

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10092: URL: https://github.com/apache/pinot/pull/10092#issuecomment-1378068990 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] elonazoulay commented on issue #10073: Segment build fails with null value for time column

2023-01-10 Thread GitBox
elonazoulay commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1378046631 Thanks @Jackie-Jiang ! Yep, the `isValidTimeInterval` is where the validation fails (as expected). -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pinot] Jackie-Jiang commented on issue #10073: Segment build fails with null value for time column

2023-01-10 Thread GitBox
Jackie-Jiang commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1378036852 No. Ideally we don't want any time value < 1971-01-01 Are you using the latest version pinot library for the offline ingestion? There should be a check on the time column valu

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9982: Reload the SegmentMetadata even for temporary forward index

2023-01-10 Thread GitBox
Jackie-Jiang commented on code in PR #9982: URL: https://github.com/apache/pinot/pull/9982#discussion_r1066443852 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseIndexHandler.java: ## @@ -41,13 +41,17 @@ public abstract class BaseInd

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
mcvsubbu commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1066440840 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @De

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
mcvsubbu commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1066440840 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @De

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10088: Add controller API for force commit status

2023-01-10 Thread GitBox
Jackie-Jiang commented on code in PR #10088: URL: https://github.com/apache/pinot/pull/10088#discussion_r1066430611 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -698,6 +698,8 @@ public static class ControllerJob { * Segment reload job Z

[pinot] branch master updated: evaluate EQ queries against range index when available (#10043)

2023-01-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b09e9e645f evaluate EQ queries against range inde

[GitHub] [pinot] Jackie-Jiang merged pull request #10043: evaluate equals queries against range index when available

2023-01-10 Thread GitBox
Jackie-Jiang merged PR #10043: URL: https://github.com/apache/pinot/pull/10043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on pull request #10087: [Clean up] Remove the support for non-zero padding

2023-01-10 Thread GitBox
Jackie-Jiang commented on PR #10087: URL: https://github.com/apache/pinot/pull/10087#issuecomment-1377996366 @ankitsultana If the segments are **created** using the version after Aug. 2016, it should be fine -- This is an automated message from the Apache Git Service. To respond to the me

[pinot] branch master updated: fix(ui): show query result along with error message if both exist (#10071)

2023-01-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 79ad59ae4d fix(ui): show query result along with

[GitHub] [pinot] Jackie-Jiang merged pull request #10071: fix(ui): show query result along with error message if both exist

2023-01-10 Thread GitBox
Jackie-Jiang merged PR #10071: URL: https://github.com/apache/pinot/pull/10071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Fix flaky ForwardIndexHandlerTest (#10093)

2023-01-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0446989ed6 Fix flaky ForwardIndexHandlerTest (#10

[GitHub] [pinot] Jackie-Jiang merged pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
Jackie-Jiang merged PR #10093: URL: https://github.com/apache/pinot/pull/10093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] egalpin commented on pull request #10092: Fixes filtered agg result column naming and filtered agg order-by compat

2023-01-10 Thread GitBox
egalpin commented on PR #10092: URL: https://github.com/apache/pinot/pull/10092#issuecomment-1377993400 I ran the previously failing tests locally, and they pass. Are the tests in `org.apache.pinot.segment.local.segment.index.loader.ForwardIndexHandlerTest` known to be flaky? https://us

[GitHub] [pinot] codecov-commenter commented on pull request #10094: [multi-stage] OpChain and operator stats

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10094: URL: https://github.com/apache/pinot/pull/10094#issuecomment-1377953527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10094?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] egalpin commented on a diff in pull request #10092: Fixes filtered agg result column naming and filtered agg order-by compat

2023-01-10 Thread GitBox
egalpin commented on code in PR #10092: URL: https://github.com/apache/pinot/pull/10092#discussion_r1066390177 ## pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/AggregationResultsBlock.java: ## @@ -69,7 +84,14 @@ public DataSchema getDataSchema(QueryConte

[GitHub] [pinot] mcvsubbu commented on issue #10095: Enable queries on individual tables during start up vs server-wide

2023-01-10 Thread GitBox
mcvsubbu commented on issue #10095: URL: https://github.com/apache/pinot/issues/10095#issuecomment-1377948767 The queries are disabled not just due to consumption catch up. In fact, the consumption part was added much later. The original intent (and that is still there) to hold queries was

[GitHub] [pinot] jugomezv opened a new issue, #10097: Introduce a realtime metric that measures times from when a record is created till it is consumed by Pinot

2023-01-10 Thread GitBox
jugomezv opened a new issue, #10097: URL: https://github.com/apache/pinot/issues/10097 PR 9994 introduces a per partition metric that measures the time between when an event was introduced in to the last-hop stream abstraction and the time Pinot consumes it. In many cases the ingestion pipe

[GitHub] [pinot] jugomezv opened a new issue, #10096: PR 9994 introduces realtime lag metric but it add a monitoring thread per table: can we use a thread for all tables

2023-01-10 Thread GitBox
jugomezv opened a new issue, #10096: URL: https://github.com/apache/pinot/issues/10096 PR 9994 introduces realtime lag metrics per partition and create a monitor thread per table to time out metrics for partitions that have been migrated out of the server: opening this to answer the followi

[GitHub] [pinot] jugomezv opened a new issue, #10095: Enable queries on individual tables during start up vs server-wide

2023-01-10 Thread GitBox
jugomezv opened a new issue, #10095: URL: https://github.com/apache/pinot/issues/10095 During recent work we found that queries are disabled server-wide for all tables during catch up stage. The goal of this issue is to study how hard it would be to enable queries on a per table basis inste

[GitHub] [pinot] jugomezv commented on issue #10049: Avoid use of checking and casting to LLRealtimeSegmentDataManager in SegmentOfflineStateModelFactory

2023-01-10 Thread GitBox
jugomezv commented on issue #10049: URL: https://github.com/apache/pinot/issues/10049#issuecomment-1377914550 But wouldn't that be cleaner? I can draft the change and you can tell us what you think. Seems to me that doing instance of breaks encapsulation. -- This is an automated message f

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10093: URL: https://github.com/apache/pinot/pull/10093#discussion_r1066362108 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -1374,7 +1373,7 @@ public void testDisab

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10093: URL: https://github.com/apache/pinot/pull/10093#discussion_r1066362108 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -1374,7 +1373,7 @@ public void testDisab

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10093: URL: https://github.com/apache/pinot/pull/10093#discussion_r1066362108 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -1374,7 +1373,7 @@ public void testDisab

[GitHub] [pinot] 61yao opened a new pull request, #10094: [mult-stage] OpChain and operator stats

2023-01-10 Thread GitBox
61yao opened a new pull request, #10094: URL: https://github.com/apache/pinot/pull/10094 Log operator and opchain stats to help better debug perf issues. In non-error case, the log is printed out as log.debug. otherwise, it is log.error. We determine the termination of an oper

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10093: URL: https://github.com/apache/pinot/pull/10093#discussion_r1066353753 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java: ## @@ -1374,7 +1373,7 @@ public void test

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066334375 ## pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java: ## @@ -1680,6 +1680,16 @@ public void testSelectAggregate() { result4.add

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066342760 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctSumAggregationFunction.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the A

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066342183 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctAvgAggregationFunction.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the A

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066340590 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseDistinctAggregateAggregationFunction.java: ## @@ -0,0 +1,504 @@ +/** + * Licens

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066335661 ## pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationSingleValueQueriesTest.java: ## @@ -568,4 +568,64 @@ public void testNumGroupsLimit(

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066335355 ## pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationSingleValueQueriesTest.java: ## @@ -255,7 +255,7 @@ public void testDistinctCount()

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066334375 ## pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java: ## @@ -1680,6 +1680,16 @@ public void testSelectAggregate() { result4.add

[GitHub] [pinot] codecov-commenter commented on pull request #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10093: URL: https://github.com/apache/pinot/pull/10093#issuecomment-1377769542 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] elonazoulay commented on issue #10073: Segment build fails with null value for time column

2023-01-10 Thread GitBox
elonazoulay commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1377745177 It is not. Just did a test inserting null for the time column. Also tested realtime: it allows null value for the time column. -- This is an automated message from the Apache G

[GitHub] [pinot] vvivekiyer opened a new pull request, #10093: Fix flaky ForwardIndexHandlerTest

2023-01-10 Thread GitBox
vvivekiyer opened a new pull request, #10093: URL: https://github.com/apache/pinot/pull/10093 This PR fixes the flaky ForwardIndexHandlerTest encountered in #9831 and https://github.com/apache/pinot/issues/10012 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pinot] egalpin commented on pull request #10092: Fixes filtered agg result column naming and filtered agg order-by compat

2023-01-10 Thread GitBox
egalpin commented on PR #10092: URL: https://github.com/apache/pinot/pull/10092#issuecomment-1377719912 cc @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] egalpin opened a new pull request, #10092: Fixes filtered agg result column naming and filtered agg order-by compat

2023-01-10 Thread GitBox
egalpin opened a new pull request, #10092: URL: https://github.com/apache/pinot/pull/10092 This PR follows up on https://github.com/apache/pinot/pull/7916 #1 (relates to https://github.com/apache/pinot/issues/7519). This PR fixes a bug with Filtered Aggregations where the result column

[GitHub] [pinot] apucher opened a new issue, #10091: Verify that pinot-server follows listener spec for http/https

2023-01-10 Thread GitBox
apucher opened a new issue, #10091: URL: https://github.com/apache/pinot/issues/10091 Via slack: ``` I've followed the [Configuring TLS/SSL #TLS only](https://docs.pinot.apache.org/operators/tutorials/configuring-tls-ssl#tls-only) guide with the Helm Chart. I have couple of questi

[pinot] branch master updated (e63ef628f3 -> 139245edea)

2023-01-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from e63ef628f3 Move the logic to modify default value for consuming segment inside RealtimeTableDataManager (#10086) a

[GitHub] [pinot] snleee merged pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
snleee merged PR #10083: URL: https://github.com/apache/pinot/pull/10083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] somandal commented on pull request #9982: Reload the SegmentMetadata even for temporary forward index

2023-01-10 Thread GitBox
somandal commented on PR #9982: URL: https://github.com/apache/pinot/pull/9982#issuecomment-1377650926 hey @Jackie-Jiang and @siddharthteotia can you review this? I've addressed all feedback so far -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pinot] klsince closed pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index

2023-01-10 Thread GitBox
klsince closed pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index URL: https://github.com/apache/pinot/pull/10077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pinot] vvivekiyer commented on pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
vvivekiyer commented on PR #10054: URL: https://github.com/apache/pinot/pull/10054#issuecomment-1377640453 @siddharthteotia and @Jackie-Jiang - addressed comments. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #10054: Add DistinctSum and DistinctAvg aggregation functions

2023-01-10 Thread GitBox
vvivekiyer commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1066095263 ## pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java: ## @@ -1783,13 +1783,111 @@ public void testDistinctCountRewrite() { }

[GitHub] [pinot] walterddr merged pull request #10086: Only set the modified default value for time columns in RealtimeTableDataManager

2023-01-10 Thread GitBox
walterddr merged PR #10086: URL: https://github.com/apache/pinot/pull/10086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[pinot] branch master updated: Move the logic to modify default value for consuming segment inside RealtimeTableDataManager (#10086)

2023-01-10 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e63ef628f3 Move the logic to modify default value

[GitHub] [pinot] codecov-commenter commented on pull request #10090: fix(ui): update table status to inline with new segment status

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10090: URL: https://github.com/apache/pinot/pull/10090#issuecomment-1377395029 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10090?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] ankitsultana commented on pull request #10087: [Clean up] Remove the support for non-zero padding

2023-01-10 Thread GitBox
ankitsultana commented on PR #10087: URL: https://github.com/apache/pinot/pull/10087#issuecomment-1377343577 > Segments generated with non-zero padding will no longer be supported. @Jackie-Jiang : Since this is enforced since 2018, I guess as long as someone is on a 2019 or a later ve

[GitHub] [pinot] jayeshchoudhary commented on pull request #10090: fix(ui): update table status to inline with new segment status

2023-01-10 Thread GitBox
jayeshchoudhary commented on PR #10090: URL: https://github.com/apache/pinot/pull/10090#issuecomment-1377308916 @npawar @joshigaurava -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] gortiz commented on a diff in pull request #10043: evaluate equals queries against range index when available

2023-01-10 Thread GitBox
gortiz commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065799086 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -44,44 +53,74 @@ public class RangeIndexBasedFilterOperator e

[GitHub] [pinot] jayeshchoudhary opened a new pull request, #10090: fix(ui): update table status to inline with new segment status

2023-01-10 Thread GitBox
jayeshchoudhary opened a new pull request, #10090: URL: https://github.com/apache/pinot/pull/10090 ## Issue - Table status was incorrect and did not reflect segment status which was recently updated (#9699) - Table status only have two status Good (IS matches EV) and Bad (IS != EV)

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065689645 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RangePredicateEvaluatorFactory.java: ## @@ -214,6 +219,16 @@ public int[] getMatching

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065675298 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -44,44 +53,74 @@ public class RangeIndexBasedFilterOp

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065674880 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -44,44 +53,74 @@ public class RangeIndexBasedFilterOp

[pinot] branch range-index-equals-queries updated (e87d5214a2 -> d11e2a9a84)

2023-01-10 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard e87d5214a2 improved modularity via parameter traits, simplify evaluation check discard cc

[pinot] branch range-index-equals-queries updated (757db3cf76 -> e87d5214a2)

2023-01-10 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard 757db3cf76 improved modularity via parameter traits, simplify evaluation check add e8

[pinot] branch range-index-equals-queries updated (dcb236d280 -> 757db3cf76)

2023-01-10 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git discard dcb236d280 improved modularity via parameter traits, simplify evaluation check add 75

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065638996 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/EqualsPredicateEvaluatorFactory.java: ## @@ -82,202 +82,6 @@ public static BaseRawVal

[pinot] branch range-index-equals-queries updated (cc0fc41546 -> dcb236d280)

2023-01-10 Thread richardstartin
This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git from cc0fc41546 simplify range index add dcb236d280 improved modularity via parameter trait

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065591440 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -44,44 +53,74 @@ public class RangeIndexBasedFilterOp

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

2023-01-10 Thread GitBox
richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1065588654 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/EqualsPredicateEvaluatorFactory.java: ## @@ -82,202 +82,6 @@ public static BaseRawVal

[GitHub] [pinot] codecov-commenter commented on pull request #10088: Add controller API for force commit status

2023-01-10 Thread GitBox
codecov-commenter commented on PR #10088: URL: https://github.com/apache/pinot/pull/10088#issuecomment-1377015471 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10088?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] saurabhd336 opened a new pull request, #10089: Reload conditional skip

2023-01-10 Thread GitBox
saurabhd336 opened a new pull request, #10089: URL: https://github.com/apache/pinot/pull/10089 Allows for option to reuse existing segment directory if reprocessing is not needed during reload. By default the flag is false -- This is an automated message from the Apache Git Servic

[GitHub] [pinot] saurabhd336 opened a new pull request, #10088: Add controller API for force commit status

2023-01-10 Thread GitBox
saurabhd336 opened a new pull request, #10088: URL: https://github.com/apache/pinot/pull/10088 Force commit is an async operation with no way of knowing how many of the segments have succesfully been forcecommited after submitting the operation. This change adds an API to be able to check i

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1065478087 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #10083: report minion task queue metrics at table level

2023-01-10 Thread GitBox
zhtaoxiang commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1065462953 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java: ## @@ -364,7 +366,46 @@ public synchronized TaskC

  1   2   >