siddharthteotia commented on code in PR #10093:
URL: https://github.com/apache/pinot/pull/10093#discussion_r1066353753
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java:
##########
@@ -1374,7 +1373,7 @@ public void testDisableForwardIndexForSingleRawColumn()
// This value is based on the rows in createTestData().
dictionaryElementSize = 7;
} else if (dataType == FieldSpec.DataType.BIG_DECIMAL) {
- dictionaryElementSize = 11;
+ dictionaryElementSize = 4;
Review Comment:
Not sure I follow the root cause ? Can you elaborate why changing this fixes
flakeyness ?
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandlerTest.java:
##########
@@ -1374,7 +1373,7 @@ public void testDisableForwardIndexForSingleRawColumn()
// This value is based on the rows in createTestData().
dictionaryElementSize = 7;
} else if (dataType == FieldSpec.DataType.BIG_DECIMAL) {
- dictionaryElementSize = 11;
+ dictionaryElementSize = 4;
Review Comment:
Not sure I follow the root cause. Can you elaborate why changing this fixes
flakeyness ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
