zhtaoxiang commented on code in PR #10083: URL: https://github.com/apache/pinot/pull/10083#discussion_r1066631552
########## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ########## @@ -529,11 +517,9 @@ public void initializeGlobalMeters() { } } + @Deprecated Review Comment: Thanks for looking into details! That's a good catch! The document is wrong, the suggested method is `setOrUpdateTableGauge(final String tableName, final G gauge, final Supplier<Long> valueSupplier)`. I will update the java doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org