richardstartin commented on code in PR #10043:
URL: https://github.com/apache/pinot/pull/10043#discussion_r1065588654
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/EqualsPredicateEvaluatorFactory.java:
##########
@@ -82,202 +82,6 @@ public static BaseRawValueBasedPredicateEvaluator
newRawValueBasedEvaluator(EqPr
}
}
- private static final class DictionaryBasedEqPredicateEvaluator extends
BaseDictionaryBasedPredicateEvaluator {
Review Comment:
I mentioned why I made this change here
https://github.com/apache/pinot/pull/10043#discussion_r1063363939
I feel the single interface approach made this less cumbersome; I wouldn't
need to care about how long the class names are for formatting reasons if the
level of coupling were reduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
