siddharthteotia commented on code in PR #9388:
URL: https://github.com/apache/pinot/pull/9388#discussion_r972674290
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/StagePlanner.java:
##
@@ -223,7 +230,25 @@ private static void updatePartitionKeys(Stag
siddharthteotia commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r972571348
##
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##
@@ -31,41 +33,58 @@
*/
public class ExpressionContext {
publ
codecov-commenter commented on PR #9390:
URL: https://github.com/apache/pinot/pull/9390#issuecomment-1248934945
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9390?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
codecov-commenter commented on PR #9409:
URL: https://github.com/apache/pinot/pull/9409#issuecomment-1248871245
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9409?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
siddharthteotia commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r972571465
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java:
##
@@ -100,7 +101,7 @@ public
Disti
siddharthteotia commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r972571348
##
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##
@@ -31,41 +33,58 @@
*/
public class ExpressionContext {
publ
siddharthteotia commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r972568072
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java:
##
@@ -58,21 +61,24 @@ public class LiteralTransformFu
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/org.yaml-snakeyaml-1.31
in repository https://gitbox.apache.org/repos/asf/pinot.git
at b62af0e13c Bump snakeyaml from 1.30 to 1.31
No new revisions were added by this
dependabot[bot] opened a new pull request, #9409:
URL: https://github.com/apache/pinot/pull/9409
Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.30 to
1.31.
Commits
https://bitbucket.org/snakeyaml/snakeyaml/commits/a3e641b8d6337d9916b5d709278fd668b0eb8507";>
siddharthteotia commented on code in PR #9406:
URL: https://github.com/apache/pinot/pull/9406#discussion_r972550066
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##
@@ -129,14 +124,44 @@ private void consumeInputBlocks() {
}
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 50cdd28e9e Benchmark thread cpu time (#9408)
add bfa2a5a23c [multistage] Initial commit to support h2 testing
siddharthteotia merged PR #9406:
URL: https://github.com/apache/pinot/pull/9406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
siddharthteotia commented on code in PR #9406:
URL: https://github.com/apache/pinot/pull/9406#discussion_r972549589
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##
@@ -129,14 +124,44 @@ private void consumeInputBlocks() {
}
siddharthteotia commented on PR #9408:
URL: https://github.com/apache/pinot/pull/9408#issuecomment-1248814766
This is just for testing some hypothesis. Essentially 10 million selectivity
can result in net ~1ms overhead
--
This is an automated message from the Apache Git Service.
To respon
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 50cdd28e9e Benchmark thread cpu time (#9408)
siddharthteotia merged PR #9408:
URL: https://github.com/apache/pinot/pull/9408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
siddharthteotia commented on PR #9408:
URL: https://github.com/apache/pinot/pull/9408#issuecomment-1248813711
Thanks. Let's check in this benchmark for future usages as we decide to use
threadCpuTime measurement in other parts of the code.
--
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2bb224cdd2 [Bugfix] schema update bug fix (#9382)
Jackie-Jiang merged PR #9382:
URL: https://github.com/apache/pinot/pull/9382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
jasperjiaguo opened a new pull request, #9408:
URL: https://github.com/apache/pinot/pull/9408
Benchmark
Mode Cnt ScoreError Units
BenchmarkThreadMXBean.benchAndFilterOperatorDegenerate avgt
codecov-commenter commented on PR #9406:
URL: https://github.com/apache/pinot/pull/9406#issuecomment-1248764919
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9406?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
codecov-commenter commented on PR #9407:
URL: https://github.com/apache/pinot/pull/9407#issuecomment-1248737074
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9407?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
tanmesh commented on issue #9075:
URL: https://github.com/apache/pinot/issues/9075#issuecomment-1248731920
@npawar Update -- PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
61yao opened a new pull request, #9407:
URL: https://github.com/apache/pinot/pull/9407
There are some flaky tests from DistinctFrom. The test failure cannot be
reproduced locally.
We compare MAX_NUM_ROWS_TO_COMPARE rows in the tests.
Increase this number for now to see if the flakiness
Jackie-Jiang commented on PR #9399:
URL: https://github.com/apache/pinot/pull/9399#issuecomment-1248694213
Can you please update the PR with the new added config keys, and the pinot
doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c9587df919 Disable logging for interrupted exceptions in kinesis
(#9405)
add 41c4aca217 set MDC so that one can r
Jackie-Jiang merged PR #9400:
URL: https://github.com/apache/pinot/pull/9400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
tanmesh commented on PR #9263:
URL: https://github.com/apache/pinot/pull/9263#issuecomment-1248692420
Putting the error message for reference.
> Error: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile
(default-testCompile) on project pinot-jdb
jackjlli commented on code in PR #9403:
URL: https://github.com/apache/pinot/pull/9403#discussion_r972452979
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -765,6 +766,28 @@ private void writeMetad
MeihanLi commented on PR #9382:
URL: https://github.com/apache/pinot/pull/9382#issuecomment-1248650236
Thanks @Jackie-Jiang for the approval. I fixed the unit tests and please
check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
MeihanLi closed pull request #9382: [Bugfix] schema update bug fix
URL: https://github.com/apache/pinot/pull/9382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
MeihanLi commented on PR #9382:
URL: https://github.com/apache/pinot/pull/9382#issuecomment-1248649119
> Please take a look at the failed tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972415292
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/ManualAuthorization.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
apucher commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972407174
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/ManualAuthorization.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c9587df919 Disable logging for interrupted excep
apucher merged PR #9405:
URL: https://github.com/apache/pinot/pull/9405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache
somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r972389654
##
pinot-core/src/main/java/org/apache/pinot/core/minion/RawIndexConverter.java:
##
@@ -204,6 +204,11 @@ private void convertColumn(FieldSpec fieldSpec)
// Create th
somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r972385553
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/stats/MutableColumnStatistics.java:
##
@@ -145,6 +146,8 @@ public boolean isSorted(
jackjlli commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r972374277
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/stats/MutableColumnStatistics.java:
##
@@ -145,6 +146,8 @@ public boolean isSorted(
jugomezv commented on issue #9310:
URL: https://github.com/apache/pinot/issues/9310#issuecomment-1248557396
> #9197
@Jackie-Jiang the plan is to have this as default code path: no config for
it. When we call reload on a mutable segement we always do forceCommit on it.
Now the only th
walterddr opened a new pull request, #9406:
URL: https://github.com/apache/pinot/pull/9406
- adding H2 connection to load the same dataset
- verify the final result against entire query resultset
--
This is an automated message from the Apache Git Service.
To respond to the message,
sajjad-moradi commented on issue #9310:
URL: https://github.com/apache/pinot/issues/9310#issuecomment-1248467590
+1 on always using force commit to reload. IMO we don't need to have a
config for this.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Jackie-Jiang commented on issue #9310:
URL: https://github.com/apache/pinot/issues/9310#issuecomment-1248447780
@jugomezv I'm a little bit confused on how you plan to enable this feature.
Are you planning to add a config flag for it and make it enabled by default?
Long term wise, I want t
jugomezv commented on issue #9310:
URL: https://github.com/apache/pinot/issues/9310#issuecomment-1248434814
The basic plan here is to fire forced commit when we invoke
reloadMutableSegment(). We will not touch or change the schema evolution change
cited above, but this change will render th
navina commented on PR #9260:
URL: https://github.com/apache/pinot/pull/9260#issuecomment-1248432667
> Hey @navina , I was looking into partition-level consume but I was unable
to find the groupid. Can you please point me to code?
As of today, we don't set any `groupId` explicitly in
sajjad-moradi commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972286109
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
sajjad-moradi commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972284881
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/ManualAuthorization.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) und
navina commented on PR #9260:
URL: https://github.com/apache/pinot/pull/9260#issuecomment-1248401279
> Does `groupId` apply to LLC consumer? I checked the usage of
`StreamConfig.getGroupId()` and I think we already handled the case of missing
group id (in `PinotTableIdealStateBuilder.getGro
tanmesh commented on PR #9263:
URL: https://github.com/apache/pinot/pull/9263#issuecomment-1248389714
I have addressed the failures in the latest commit. @Jackie-Jiang can you
plz review and re-run the CI test ?
--
This is an automated message from the Apache Git Service.
To respond to t
jugomezv commented on issue #9310:
URL: https://github.com/apache/pinot/issues/9310#issuecomment-1248373198
I talked to @sajjad-moradi on taking this one, I will sync with him and
assign to me after the discussion
--
This is an automated message from the Apache Git Service.
To respond to
codecov-commenter commented on PR #9405:
URL: https://github.com/apache/pinot/pull/9405#issuecomment-1248371923
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
tanmesh commented on PR #9260:
URL: https://github.com/apache/pinot/pull/9260#issuecomment-1248366998
> Tks for contributing this feature. Can you please extend this feature to
partition-level consumer as well?
Hey @navina , I was looking into partition-level consume but I was unable
richardstartin commented on issue #9402:
URL: https://github.com/apache/pinot/issues/9402#issuecomment-1248355885
Linking #7597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
richardstartin commented on issue #9402:
URL: https://github.com/apache/pinot/issues/9402#issuecomment-1248354947
Note that the data structure backing the range index supports passing a
bitmap which represents filtering already done, but isn't used in Pinot. If
filter bitmaps were passed on
KKcorps opened a new pull request, #9405:
URL: https://github.com/apache/pinot/pull/9405
Almost all of these logs are due to an Interrupted signal from the main
thread because of fetch timeouts. It pollutes the log with irrelevant log
messages and hence needs to be removed.
--
This is an
dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972169945
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972168144
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972167421
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity
requesterIdentity) {
dongxiaoman commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r972165082
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/ManualAuthorization.java:
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
bagipriyank commented on issue #9393:
URL: https://github.com/apache/pinot/issues/9393#issuecomment-1248122139
> Do you have the server connected to the cluster when you delete the
segments?
Yes
I tried waiting but I don't see any files getting deleted even after a day.
--
This
kishoreg commented on issue #9402:
URL: https://github.com/apache/pinot/issues/9402#issuecomment-1248117288
You have an OR clause on last payment which will result in full scan.. add
range index on last payment and this will be very fast
--
This is an automated message from the Apache Git
KKcorps commented on PR #9403:
URL: https://github.com/apache/pinot/pull/9403#issuecomment-1248110433
For now, only moved the code from previous PR (#9355) .
Last comments by @Jackie-Jiang
> We don't want to change the start/end time within the segment metadata,
instead we want t
KKcorps opened a new pull request, #9403:
URL: https://github.com/apache/pinot/pull/9403
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `
priyen opened a new issue, #9402:
URL: https://github.com/apache/pinot/issues/9402
We have this query, ```
SELECT
"customer_id"
FROM
"table name"
WHERE
"_viewing_merchant" = 'some merchant id'
AND ((
"customer_id" < 'some customer id'
AND "last_pay
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971763327
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDataDecoderImpl.java:
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971758726
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageMetadata.java:
##
@@ -18,26 +18,38 @@
*/
package org.apache.pinot.spi.stream;
+import javax.annotat
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971758010
##
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConsumer.java:
##
@@ -43,30 +45,36 @@ public
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971756569
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDataDecoderImpl.java:
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971756300
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeClusterIntegrationTest.java:
##
@@ -76,6 +76,8 @@ public void setUp()
// Wait for
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971755233
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##
@@ -31,6 +32,8 @@
@InterfaceAudience.Public
@InterfaceStability.Evolving
public interface Row
navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971747264
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageMetadata.java:
##
@@ -18,26 +18,38 @@
*/
package org.apache.pinot.spi.stream;
+import javax.annotat
siddharthteotia commented on issue #9401:
URL: https://github.com/apache/pinot/issues/9401#issuecomment-1247724922
I don't think this has got anything to do with IN_SUBQUERY.
It will probably fail (for the same reason) if you just run the ID_SET query
alone.
Are you trying to
siddharthteotia commented on PR #8979:
URL: https://github.com/apache/pinot/pull/8979#issuecomment-1247719106
Seems like a great optimization. Any plans of resuming this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
73 matches
Mail list logo
