navina commented on PR #9260: URL: https://github.com/apache/pinot/pull/9260#issuecomment-1248401279
> Does `groupId` apply to LLC consumer? I checked the usage of `StreamConfig.getGroupId()` and I think we already handled the case of missing group id (in `PinotTableIdealStateBuilder.getGroupIdFromRealtimeDataTable()`). @navina In which scenario are we getting the `null` group id? I was not aware of the `PinotTableIdealStateBuilder.getGroupIdFromRealtimeDataTable()` usage. But when the kafka consumer client config doesn't contain `group.id`, the kafka consumer created ends up using `null` as group id. Previously, it would default to empty string. This is breaking monitoring tools for existing users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
