KKcorps commented on PR #9403: URL: https://github.com/apache/pinot/pull/9403#issuecomment-1248110433
For now, only moved the code from previous PR (#9355) . Last comments by @Jackie-Jiang > We don't want to change the start/end time within the segment metadata, instead we want to enhance the time management code to gracefully handle the segments with invalid time values. > Suggest using a separate PR for the time management change, and only keep the sample value check in this PR. The new flag `skipSegmentTimeCheck: true` allows ingestion to not fail because of timestamp issues. As far as updating the timestamps in metadata is concerned, we need to find a way for users to specify the correct time-formats. The issue is we don't allow backward-incompatible change in the schema so if an user fixes the segment metadata timestamp via some new API, we won't be able to reflect those changes in the schema. This inconsistency may break a lot of things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
