navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r971755233
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -31,6 +32,8 @@
@InterfaceAudience.Public
@InterfaceStability.Evolving
public interface RowMetadata {
+ GenericRow EMPTY_ROW = new GenericRow();
Review Comment:
I agree with you about the confusion. I was trying not to blow up/break
existing interfaces in pinot-spi.
Let me create a separate PR that just renames `RowMetadata` into
`StreamMessageMetadata`. I want to avoid using the term "row" when we talk
about input from a stream. I find that confusing :/
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDataDecoderResult.java:
##########
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.stream;
+
+import org.apache.pinot.spi.data.readers.GenericRow;
+
+
+/**
+ * A container class for holding the result of a decoder
+ * At any point in time, only one of Result or exception is set as null.
+ */
+public final class StreamDataDecoderResult {
+ private final GenericRow _result;
+ private final Exception _exception;
+
+ public StreamDataDecoderResult(GenericRow result, Exception exception) {
+ _result = result;
+ _exception = exception;
+ }
+
+ public GenericRow getResult() {
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
