siddharthteotia commented on code in PR #9388:
URL: https://github.com/apache/pinot/pull/9388#discussion_r972674290


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/StagePlanner.java:
##########
@@ -223,7 +230,25 @@ private static void updatePartitionKeys(StageNode node) {
       }
       node.setPartitionKeys(newPartitionKeys);
     } else if (node instanceof TableScanNode) {
-      // TODO: add table partition in table config as partition keys. we dont 
have that information yet.
+      TableScanNode tableScanNode = (TableScanNode) node;
+      TableConfig tableConfig =
+          _tableCache.getTableConfig(tableScanNode.getTableName());
+      Preconditions.checkNotNull(tableConfig, "table config is null");

Review Comment:
   I think this should be handled imo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to