[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] vvivekiyer commented on a change in pull request #8110: Extend enableParallePushProtection support in UploadSegment API

2022-02-01 Thread GitBox
vvivekiyer commented on a change in pull request #8110: URL: https://github.com/apache/pinot/pull/8110#discussion_r797316676 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java ## @@ -810,6 +810,33 @@ public SimpleHttpResponse u

[GitHub] [pinot] vvivekiyer opened a new pull request #8110: Extend enableParallePushProtection support in UploadSegment API

2022-02-01 Thread GitBox
vvivekiyer opened a new pull request #8110: URL: https://github.com/apache/pinot/pull/8110 The current implementation doesn't protect against concurrent UploadSegment calls for a non-existing segment. The current implementation of ProcessNewSegment is as follows: 1. Move segment

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
siddharthteotia commented on a change in pull request #8105: URL: https://github.com/apache/pinot/pull/8105#discussion_r797303905 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java ## @@ -119,22 +120,31 @@ public AsyncQueryResponse submitQu

[GitHub] [pinot] siddharthteotia commented on a change in pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
siddharthteotia commented on a change in pull request #8105: URL: https://github.com/apache/pinot/pull/8105#discussion_r797303905 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java ## @@ -119,22 +120,31 @@ public AsyncQueryResponse submitQu

[GitHub] [pinot] suddendust commented on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
suddendust commented on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1027621772 Thanks everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[pinot] branch master updated: [7867] Handle Select * with Extra Columns (#7959)

2022-02-01 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ea2f0aa [7867] Handle Select * with Extra Co

[GitHub] [pinot] siddharthteotia merged pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
siddharthteotia merged pull request #7959: URL: https://github.com/apache/pinot/pull/7959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] vijaya-lakshmi-venkatraman commented on issue #6487: Adding numStartreeUsed in query stats

2022-02-01 Thread GitBox
vijaya-lakshmi-venkatraman commented on issue #6487: URL: https://github.com/apache/pinot/issues/6487#issuecomment-1027602449 Hello, I would like to give a try if this is still available. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] vijaya-lakshmi-venkatraman commented on issue #6328: Improvement: Show "table not found" info in wrong query

2022-02-01 Thread GitBox
vijaya-lakshmi-venkatraman commented on issue #6328: URL: https://github.com/apache/pinot/issues/6328#issuecomment-1027592394 HI, I see that there is a merged PR associated with this issue. Is this still open? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] branch master updated: fix controller config validation failure for customized TLS listeners (#8106)

2022-02-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d08c7f8 fix controller config validation failur

[GitHub] [pinot] apucher merged pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
apucher merged pull request #8106: URL: https://github.com/apache/pinot/pull/8106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8108: URL: https://github.com/apache/pinot/pull/8108#issuecomment-1027476585 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8108: URL: https://github.com/apache/pinot/pull/8108#issuecomment-1027476585 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8108: URL: https://github.com/apache/pinot/pull/8108#issuecomment-1027476585 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8109: add pinot.minion prefix on minion configs for consistency

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8109: URL: https://github.com/apache/pinot/pull/8109#issuecomment-1027509654 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] dongxiaoman commented on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman commented on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027512625 > High level, this is good. Question on other components, what if we want to apply same mechanism for controller/server/minion restful resources? Shall we rename ServiceAutoD

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8109: add pinot.minion prefix on minion configs for consistency

2022-02-01 Thread GitBox
codecov-commenter commented on pull request #8109: URL: https://github.com/apache/pinot/pull/8109#issuecomment-1027509654 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8105: URL: https://github.com/apache/pinot/pull/8105#issuecomment-1027297458 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] klsince opened a new pull request #8109: add pinot.minion prefix on minion configs for consistency

2022-02-01 Thread GitBox
klsince opened a new pull request #8109: URL: https://github.com/apache/pinot/pull/8109 ## Description added `pinot.minion.` prefix on minion configs for consistency, but keeping the old config names for backward compatibility. ## Upgrade Notes Does this PR prevent a zero

[GitHub] [pinot] siddharthteotia commented on pull request #8055: Support BOOLEAN type in recommender engine

2022-02-01 Thread GitBox
siddharthteotia commented on pull request #8055: URL: https://github.com/apache/pinot/pull/8055#issuecomment-1027483572 @lksvenoy-r7 , there are lots of `connection refused` exceptions in the quickstart test which don't seem to be related to changes made here. If not done already, can you

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8105: URL: https://github.com/apache/pinot/pull/8105#issuecomment-1027297458 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
codecov-commenter commented on pull request #8108: URL: https://github.com/apache/pinot/pull/8108#issuecomment-1027476585 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] siddharthteotia commented on pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
siddharthteotia commented on pull request #7959: URL: https://github.com/apache/pinot/pull/7959#issuecomment-1027446141 @suddendust can you please take a look at the failing tests ? We can then merge this -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pinot] apucher commented on a change in pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
apucher commented on a change in pull request #8106: URL: https://github.com/apache/pinot/pull/8106#discussion_r797182792 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ## @@ -379,16 +379,16 @@ public String getInstanceId() {

[pinot] branch listener-tls-customization-validation-fixes updated (4c742fb -> 4c743b8)

2022-02-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch listener-tls-customization-validation-fixes in repository https://gitbox.apache.org/repos/asf/pinot.git. from 4c742fb fix config config validation failure for custom TLS listeners add

[GitHub] [pinot] deemoliu commented on pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
deemoliu commented on pull request #8108: URL: https://github.com/apache/pinot/pull/8108#issuecomment-1027419170 cc: @yupeng9 @chenboat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pinot] deemoliu opened a new pull request #8108: add tools for upsert table heap usage estimation

2022-02-01 Thread GitBox
deemoliu opened a new pull request #8108: URL: https://github.com/apache/pinot/pull/8108 Per #6729, add a tool to estimate heap usage for upsert table keySpace and valueSpace Calculated keySpace by the following formula UpsertFrequency = 1 - (nums of records / nums of skipUpse

[GitHub] [pinot] xiangfu0 commented on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
xiangfu0 commented on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027401844 High level, this is good. Question on other components, what if we want to apply same mechanism for controller/server/minion restful resources? Shall we rename ServiceAutoD

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8100: URL: https://github.com/apache/pinot/pull/8100#issuecomment-1026775031 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
codecov-commenter commented on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027390048 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter commented on pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
codecov-commenter commented on pull request #8106: URL: https://github.com/apache/pinot/pull/8106#issuecomment-1027386862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8106?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8100: URL: https://github.com/apache/pinot/pull/8100#issuecomment-1026775031 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] mayankshriv commented on a change in pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
mayankshriv commented on a change in pull request #8106: URL: https://github.com/apache/pinot/pull/8106#discussion_r797135095 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ## @@ -379,16 +379,16 @@ public String getInstanceId() {

[GitHub] [pinot] richardstartin closed pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
richardstartin closed pull request #8101: URL: https://github.com/apache/pinot/pull/8101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pinot] richardstartin commented on pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
richardstartin commented on pull request #8101: URL: https://github.com/apache/pinot/pull/8101#issuecomment-1027376590 Yes, and many of the strings will be duplicated across many of those 10K segments too. You illustrate well how much memory bandwidth the query layer requires, because each

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman commented on a change in pull request #8107: URL: https://github.com/apache/pinot/pull/8107#discussion_r797124165 ## File path: pinot-integration-tests/pom.xml ## @@ -373,5 +381,10 @@ org.mockito mockito-core + + org.glassfish.hk2 +

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman commented on a change in pull request #8107: URL: https://github.com/apache/pinot/pull/8107#discussion_r797122341 ## File path: pinot-integration-tests/src/main/java/org/apache/pinot/broker/integration/tests/BrokerTestAutoLoadedService.java ## @@ -0,0 +1,30 @@ +/**

[GitHub] [pinot] walterddr commented on a change in pull request #7719: add a build/ folder symlink to bin_dist

2022-02-01 Thread GitBox
walterddr commented on a change in pull request #7719: URL: https://github.com/apache/pinot/pull/7719#discussion_r797122464 ## File path: pinot-distribution/pom.xml ## @@ -262,6 +262,43 @@ org.apache.maven.plugins maven-enforcer-plugin +

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman commented on a change in pull request #8107: URL: https://github.com/apache/pinot/pull/8107#discussion_r797122341 ## File path: pinot-integration-tests/src/main/java/org/apache/pinot/broker/integration/tests/BrokerTestAutoLoadedService.java ## @@ -0,0 +1,30 @@ +/**

[GitHub] [pinot] dongxiaoman commented on a change in pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman commented on a change in pull request #8107: URL: https://github.com/apache/pinot/pull/8107#discussion_r797118045 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/ServiceAutoDiscoveryFeature.java ## @@ -0,0 +1,94 @@ +/** + * Licensed to the A

[GitHub] [pinot] dongxiaoman opened a new pull request #8107: Add discovery feature for broker to auto load services

2022-02-01 Thread GitBox
dongxiaoman opened a new pull request #8107: URL: https://github.com/apache/pinot/pull/8107 ## Description Added an optional "Auto Discovery" feature in PinotBroker so services tagged with `@Service` tag can be auto-loaded. This will make Pinot Broker's Jersey behave very simi

[GitHub] [pinot] apucher opened a new pull request #8106: fix controller config validation failure for customized TLS listeners

2022-02-01 Thread GitBox
apucher opened a new pull request #8106: URL: https://github.com/apache/pinot/pull/8106 ## Description This is a fix of a config validation error when using the new TLS listerner specs intoduced in #8082. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume u

[pinot] 01/01: fix config config validation failure for custom TLS listeners

2022-02-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch listener-tls-customization-validation-fixes in repository https://gitbox.apache.org/repos/asf/pinot.git commit 4c742fb0b2dab6799c72b381e3cc5d75e8276ab0 Author: Alexander Pucher AuthorDate: Tue F

[pinot] branch listener-tls-customization-validation-fixes created (now 4c742fb)

2022-02-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch listener-tls-customization-validation-fixes in repository https://gitbox.apache.org/repos/asf/pinot.git. at 4c742fb fix config config validation failure for custom TLS listeners This bra

[GitHub] [pinot] Jackie-Jiang commented on pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
Jackie-Jiang commented on pull request #8101: URL: https://github.com/apache/pinot/pull/8101#issuecomment-1027349581 The `_paddedStrings` should not be setup in normal case (it's for backward-compatibility for some very old segment format). The map is used for looking up dict id, which is

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7719: add a build/ folder symlink to bin_dist

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #7719: URL: https://github.com/apache/pinot/pull/7719#issuecomment-962758954 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7719?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] siddharthteotia commented on pull request #8055: Support BOOLEAN type in recommender engine

2022-02-01 Thread GitBox
siddharthteotia commented on pull request #8055: URL: https://github.com/apache/pinot/pull/8055#issuecomment-1027330263 Restarted the jobs. If fails again, I will take a look to see what's going on. The other PR that touched recommendation engine didn't see this https://github.com/apache/p

[GitHub] [pinot] mqliang closed pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
mqliang closed pull request #8105: URL: https://github.com/apache/pinot/pull/8105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] mcvsubbu commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
mcvsubbu commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r797068163 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void a

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7719: add a build/ folder symlink to bin_dist

2022-02-01 Thread GitBox
xiangfu0 commented on a change in pull request #7719: URL: https://github.com/apache/pinot/pull/7719#discussion_r797067892 ## File path: pinot-distribution/pom.xml ## @@ -262,6 +262,43 @@ org.apache.maven.plugins maven-enforcer-plugin +

[GitHub] [pinot] walterddr commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
walterddr commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r797047361 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void

[GitHub] [pinot] walterddr commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
walterddr commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r797047361 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void

[GitHub] [pinot] mcvsubbu commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
mcvsubbu commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r797046594 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void a

[GitHub] [pinot] mcvsubbu commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
mcvsubbu commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r797045859 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void a

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8105: URL: https://github.com/apache/pinot/pull/8105#issuecomment-1027297458 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or when send request to server

2022-02-01 Thread GitBox
codecov-commenter commented on pull request #8105: URL: https://github.com/apache/pinot/pull/8105#issuecomment-1027297458 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] mqliang opened a new pull request #8105: Add a broker metric to distinguish exception happens when acquire channel lock or send request to server

2022-02-01 Thread GitBox
mqliang opened a new pull request #8105: URL: https://github.com/apache/pinot/pull/8105 ## Description This is a follow up of: https://github.com/apache/pinot/pull/8083 This metric can help distinguish the exception: * happens when acquire channel lock, or * after ac

[GitHub] [pinot] walterddr commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
walterddr commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r796993251 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public void

[GitHub] [pinot] richardstartin commented on pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
richardstartin commented on pull request #8101: URL: https://github.com/apache/pinot/pull/8101#issuecomment-1027250871 Looking at `OnHeapStringDictionary`, it's much heavier than an intern table: ```java private final String[] _unpaddedStrings; private final Object2IntOpenHa

[GitHub] [pinot] npawar closed issue #4345: Config to make realtime non-winner servers download the segment instead of build

2022-02-01 Thread GitBox
npawar closed issue #4345: URL: https://github.com/apache/pinot/issues/4345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] npawar closed issue #5351: Transformations using columns which themselves are a result of transformation

2022-02-01 Thread GitBox
npawar closed issue #5351: URL: https://github.com/apache/pinot/issues/5351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] npawar closed issue #8052: isLiveTable check breaks Kinesis like streams

2022-02-01 Thread GitBox
npawar closed issue #8052: URL: https://github.com/apache/pinot/issues/8052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] richardstartin commented on a change in pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8100: URL: https://github.com/apache/pinot/pull/8100#discussion_r796931635 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java ## @@ -0,0 +1,100

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #8100: URL: https://github.com/apache/pinot/pull/8100#discussion_r796929462 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java ## @@ -0,0 +1,100 @@

[GitHub] [pinot] richardstartin commented on pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
richardstartin commented on pull request #8101: URL: https://github.com/apache/pinot/pull/8101#issuecomment-1027209667 > High level question: the improvement in this PR is very similar to the `OnHeapStringDictionary`. I am thinking maybe we should just use `OnHeapStringDictionary` if the d

[pinot] branch master updated (86fe41e -> 3c98a44)

2022-02-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 86fe41e Timeout if waiting server channel lock takes a long time (#8083) add 3c98a44 lock free DimensionDataTa

[GitHub] [pinot] Jackie-Jiang merged pull request #8102: lock free DimensionDataTableManager

2022-02-01 Thread GitBox
Jackie-Jiang merged pull request #8102: URL: https://github.com/apache/pinot/pull/8102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] richardstartin commented on a change in pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8101: URL: https://github.com/apache/pinot/pull/8101#discussion_r796926613 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/StringDictionary.java ## @@ -41,84 +47,117 @@ p

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8100: URL: https://github.com/apache/pinot/pull/8100#issuecomment-1026775031 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8103: add segment zk metadata check before creating a table

2022-02-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #8103: URL: https://github.com/apache/pinot/pull/8103#discussion_r796915607 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1270,6 +1270,11 @@ public vo

[GitHub] [pinot] richardstartin commented on a change in pull request #8102: lock free DimensionDataTableManager

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8102: URL: https://github.com/apache/pinot/pull/8102#discussion_r796915319 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java ## @@ -75,16 +72,10 @@ public stati

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8078: Segment retention for table

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8078: URL: https://github.com/apache/pinot/pull/8078#issuecomment-1024492127 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8102: lock free DimensionDataTableManager

2022-02-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #8102: URL: https://github.com/apache/pinot/pull/8102#discussion_r796913913 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java ## @@ -75,16 +72,10 @@ public static

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
codecov-commenter edited a comment on pull request #8100: URL: https://github.com/apache/pinot/pull/8100#issuecomment-1026775031 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8101: intern strings extracted from small dictionaries

2022-02-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #8101: URL: https://github.com/apache/pinot/pull/8101#discussion_r796908219 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/StringDictionary.java ## @@ -41,84 +47,117 @@ pub

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7959: [7867] Handle Select * with Extra Columns

2022-02-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #7959: URL: https://github.com/apache/pinot/pull/7959#discussion_r796902219 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -1459,8 +1460,18 @@ static void up

[pinot] branch master updated: Timeout if waiting server channel lock takes a long time (#8083)

2022-02-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 86fe41e Timeout if waiting server channel lock t

[GitHub] [pinot] Jackie-Jiang merged pull request #8083: Timeout if waiting server channel lock takes a long time

2022-02-01 Thread GitBox
Jackie-Jiang merged pull request #8083: URL: https://github.com/apache/pinot/pull/8083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated: Upgrade to JsonPath 2.7.0 (#7819)

2022-02-01 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3f76154 Upgrade to JsonPath 2.7.0 (#7819) 3f7615

[GitHub] [pinot] Jackie-Jiang merged pull request #7819: Upgrade to JsonPath 2.7.0

2022-02-01 Thread GitBox
Jackie-Jiang merged pull request #7819: URL: https://github.com/apache/pinot/pull/7819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] richardstartin commented on a change in pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8100: URL: https://github.com/apache/pinot/pull/8100#discussion_r796885572 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java ## @@ -0,0 +1,100

[GitHub] [pinot] richardstartin commented on a change in pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8100: URL: https://github.com/apache/pinot/pull/8100#discussion_r796885302 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java ## @@ -0,0 +1,100

[GitHub] [pinot] richardstartin commented on a change in pull request #8100: add least and greatest functions

2022-02-01 Thread GitBox
richardstartin commented on a change in pull request #8100: URL: https://github.com/apache/pinot/pull/8100#discussion_r796885007 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java ## @@ -0,0 +1,100

  1   2   >