dongxiaoman opened a new pull request #8107: URL: https://github.com/apache/pinot/pull/8107
## Description <!-- Add a description of your PR here. A good description should include pointers to an issue or design document, etc. --> Added an optional "Auto Discovery" feature in PinotBroker so services tagged with `@Service` tag can be auto-loaded. This will make Pinot Broker's Jersey behave very similar like Spring Framework in terms of service discovery. 1. Main idea is behind [mkyong's article in detail in here](https://mkyong.com/webservices/jax-rs/jersey-and-hk2-dependency-injection-auto-scanning/) 2. Added a property boolean named `pinot.broker.service.auto.discovery` to enable this behavior ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) No Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) No Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options: `pinot.broker.service.auto.discovery` so Jersey services can be created automatically and then later injected to Endpoints. - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> Release note: Added Service Auto-discovery feature into PinotBroker so classes annotated with `@Service` and built with `hk2-metadata-generator` module can be automatically loaded. <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
