richardstartin commented on pull request #8101:
URL: https://github.com/apache/pinot/pull/8101#issuecomment-1027250871


   Looking at `OnHeapStringDictionary`, it's much heavier than an intern table:
   
   ```java
     private final String[] _unpaddedStrings;
     private final Object2IntOpenHashMap<String> _unPaddedStringToIdMap;
     private final String[] _paddedStrings;
   ```
   
   The padded strings and string to id map don't serve much purpose on the hot 
path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to