dongxiaoman commented on pull request #8107: URL: https://github.com/apache/pinot/pull/8107#issuecomment-1027512625
> High level, this is good. Question on other components, what if we want to apply same mechanism for controller/server/minion restful resources? Shall we rename ServiceAutoDiscoveryFeature to BrokerServiceAutoDiscoveryFeature? Good question, I was thinking about enabling the same feature for controller/server/minion too, so did not call it `BrokerServiceAutoDiscoveryFeature`. Renamed to **BrokerServiceAutoDiscoveryFeature** for now. We can always refactor and enable later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
