mayankshriv commented on a change in pull request #8106:
URL: https://github.com/apache/pinot/pull/8106#discussion_r797135095
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -379,16 +379,16 @@ public String getInstanceId() {
getControllerPort() == null ? Arrays.asList("http") : Arrays.asList());
}
- public String getControllerAccessProtocolProperty(String protocol, String
property) {
- return getProperty(CONTROLLER_ACCESS_PROTOCOLS + "." + protocol + "." +
property);
+ public String getControllerAccessProtocolProperty(String name, String
property) {
Review comment:
Is this a backward incompatible change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
