[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7021: Move KafkaJsonDecoder code to pinot-json

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7021: URL: https://github.com/apache/incubator-pinot/pull/7021#issuecomment-854358210 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7021: Move KafkaJsonDecoder code to pinot-json

2021-06-03 Thread GitBox
codecov-commenter commented on pull request #7021: URL: https://github.com/apache/incubator-pinot/pull/7021#issuecomment-854358210 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7020: Changed compat tester to make yaml files optional

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7020: URL: https://github.com/apache/incubator-pinot/pull/7020#issuecomment-854343087 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7020?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7020: Changed compat tester to make yaml files optional

2021-06-03 Thread GitBox
codecov-commenter commented on pull request #7020: URL: https://github.com/apache/incubator-pinot/pull/7020#issuecomment-854343087 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7020?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] KKcorps opened a new pull request #7021: Move KafkaJsonDecoder code to pinot-json

2021-06-03 Thread GitBox
KKcorps opened a new pull request #7021: URL: https://github.com/apache/incubator-pinot/pull/7021 Currently, JSONDecoder for realtime data is present in KafkaJSONMessageDecoder class. However, with new realtime integrations of Kinesis and Pulsar in the pipeline, it doesn't make sense to im

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

2021-06-03 Thread GitBox
wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r645271450 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderByMultiValueQueriesTest.java ## @@ -41,6 +42,43 @@ public void te

[GitHub] [incubator-pinot] siddharthteotia closed issue #6858: Fix the race condition in realtime text index refresh thread

2021-06-03 Thread GitBox
siddharthteotia closed issue #6858: URL: https://github.com/apache/incubator-pinot/issues/6858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6858: Fix the race condition in realtime text index refresh thread

2021-06-03 Thread GitBox
siddharthteotia commented on issue #6858: URL: https://github.com/apache/incubator-pinot/issues/6858#issuecomment-854337371 Closed by PR - https://github.com/apache/incubator-pinot/pull/6990 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6796: Add realtime text index segment back to queue in the refresh thread

2021-06-03 Thread GitBox
siddharthteotia commented on issue #6796: URL: https://github.com/apache/incubator-pinot/issues/6796#issuecomment-854337064 Closed by PR - https://github.com/apache/incubator-pinot/pull/6800 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] siddharthteotia closed issue #6796: Add realtime text index segment back to queue in the refresh thread

2021-06-03 Thread GitBox
siddharthteotia closed issue #6796: URL: https://github.com/apache/incubator-pinot/issues/6796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] siddharthteotia closed issue #6937: Fix the handling of time and date time columns in rule engine

2021-06-03 Thread GitBox
siddharthteotia closed issue #6937: URL: https://github.com/apache/incubator-pinot/issues/6937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6937: Fix the handling of time and date time columns in rule engine

2021-06-03 Thread GitBox
siddharthteotia commented on issue #6937: URL: https://github.com/apache/incubator-pinot/issues/6937#issuecomment-854336978 Closed by PR - https://github.com/apache/incubator-pinot/pull/6938 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7020: Changed compat tester to make yaml files optional

2021-06-03 Thread GitBox
jackjlli commented on a change in pull request #7020: URL: https://github.com/apache/incubator-pinot/pull/7020#discussion_r645266123 ## File path: compatibility-verifier/compCheck.sh ## @@ -287,90 +287,120 @@ fi # Setup initial cluster with olderCommit and do rolling upgrade

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

2021-06-03 Thread GitBox
wuwenw commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r645266054 ## File path: pinot-core/src/test/java/org/apache/pinot/core/data/table/TableResizerTest.java ## @@ -65,6 +76,33 @@ public void setUp() {

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #7020: Changed compat tester to make yaml files optional

2021-06-03 Thread GitBox
mcvsubbu opened a new pull request #7020: URL: https://github.com/apache/incubator-pinot/pull/7020 A test suite may choose to specify test operations for some stages and not others. Also fixed a typo in "basename" ## Description ## Upgrade Notes Does this PR preven

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#issuecomment-853476127 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#issuecomment-853476127 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated: Resolve bug in HelixServerStarter for populating environment property map field and remame timeout variables to follow timeunit convention (#7019)

2021-06-03 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 1d1bf4d Resolve bug in HelixServerSt

[GitHub] [incubator-pinot] mcvsubbu merged pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
mcvsubbu merged pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7013: Produce GenericRow file in segment processing mapper

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7013: URL: https://github.com/apache/incubator-pinot/pull/7013#discussion_r645211296 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentMapper.java ## @@ -55,98 +59,113 @@ * - p

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7013: Produce GenericRow file in segment processing mapper

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7013: URL: https://github.com/apache/incubator-pinot/pull/7013#discussion_r645211044 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentMapper.java ## @@ -55,98 +59,113 @@ * - p

[incubator-pinot] branch tls-integration-test updated (4fd29d3 -> 67d3d3d)

2021-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch tls-integration-test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4fd29d3 deprecation messages for legacy https in segment uploader add 67d3d3d cleanup

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645209309 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ## @@

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645209149 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java ## @@ -23,30 +23,49 @@

[GitHub] [incubator-pinot] apucher commented on pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#issuecomment-854265623 appreciated. added deprecation annotations and comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
desaijay230592 commented on a change in pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645206735 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ##

[incubator-pinot] branch tls-integration-test updated (b7068ca -> 4fd29d3)

2021-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch tls-integration-test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b7068ca review fixes 2 add 4fd29d3 deprecation messages for legacy https in segment up

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
mcvsubbu commented on a change in pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645207650 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ## @@ -40

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
desaijay230592 commented on a change in pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645206735 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ##

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645205644 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java ## @@ -131,6 +131,27 @@ protected void st

[incubator-pinot] branch tls-integration-test updated (3b9cfff -> b7068ca)

2021-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch tls-integration-test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3b9cfff review fixes add b7068ca review fixes 2 No new revisions were added by this u

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645203205 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java ## @@ -64,6 +65,7 @@ public s

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645198813 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java ## @@ -158,8 +159,17 @@ protected void startCo

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645195262 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ## @@

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#issuecomment-854244524 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7019?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645188315 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java ## @@ -23,30 +23,

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
codecov-commenter commented on pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019#issuecomment-854244524 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7019?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] desaijay230592 opened a new pull request #7019: Resolve bug in HelixServerStarter for populating environment property…

2021-06-03 Thread GitBox
desaijay230592 opened a new pull request #7019: URL: https://github.com/apache/incubator-pinot/pull/7019 … map field and rename timeout variables to follow timeunit convention ## Description There was a bug in the HelixServerStarter code which would prevent us to update zookeeper

[incubator-pinot] branch tls-integration-test updated (8f97bd7 -> 3b9cfff)

2021-06-03 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch tls-integration-test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8f97bd7 handle rebase changes and no-init tests add 3b9cfff review fixes No new revis

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645170448 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java ## @@ -79,7 +79,7 @@ */ public abstrac

[GitHub] [incubator-pinot] apucher commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
apucher commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645170179 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionFactory.java ## @@ -40,20 +37,20 @@ private Connect

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7013: Produce GenericRow file in segment processing mapper

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7013: URL: https://github.com/apache/incubator-pinot/pull/7013#discussion_r645160191 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/ConcatCollector.java ## @@ -40,60 +41,39 @@ * A

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r644984885 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/IntermediateRecord.java ## @@ -0,0 +1,44 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] GSharayu opened a new issue #7018: Changes in inverted index rule engine to handle DateTime column

2021-06-03 Thread GitBox
GSharayu opened a new issue #7018: URL: https://github.com/apache/incubator-pinot/issues/7018 QueryInvertedSortedIndexRecommender - InvertedSortedIndexJointRule queries with tables that have time column (deprecated) or one or more DateTime columns (new way of specifying time columns) but d

[GitHub] [incubator-pinot] npawar commented on a change in pull request #7013: Produce GenericRow file in segment processing mapper

2021-06-03 Thread GitBox
npawar commented on a change in pull request #7013: URL: https://github.com/apache/incubator-pinot/pull/7013#discussion_r645103605 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessingUtils.java ## @@ -0,0 +1,82 @@ +/** + * Lic

[GitHub] [incubator-pinot] lakshmanan-v edited a comment on issue #7014: Add HLL++ support for better accuracy and possibly lower memory cost

2021-06-03 Thread GitBox
lakshmanan-v edited a comment on issue #7014: URL: https://github.com/apache/incubator-pinot/issues/7014#issuecomment-854110461 Good point @Jackie-Jiang. We could add this as a separate function DISTINCTCOUNDATASKETCHHLL (similar to DISTINCTCOUNTTHETASKETCH). It would be nice to document

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7010: Cross-integration test of Realtime & Basic Auth & TLS

2021-06-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #7010: URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645062551 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionFactory.java ## @@ -40,20 +37,20 @@ private Co

[GitHub] [incubator-pinot] lakshmanan-v commented on issue #7014: Add HLL++ support for better accuracy and possibly lower memory cost

2021-06-03 Thread GitBox
lakshmanan-v commented on issue #7014: URL: https://github.com/apache/incubator-pinot/issues/7014#issuecomment-854110461 Good point @Jackie-Jiang. We could add this as a separate function DISTINCTCOUNTHLLSKETCH (similar to DISTINCTCOUNTTHETASKETCH). It would be nice to document the parame

[GitHub] [incubator-pinot] singalravi opened a new pull request #7017: Add aws sts dependency to enable auth using web identity token.

2021-06-03 Thread GitBox
singalravi opened a new pull request #7017: URL: https://github.com/apache/incubator-pinot/pull/7017 see comment in aws-sdk-java-v2 repo: https://github.com/aws/aws-sdk-java-v2/blob/2.13.46/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/WebIdentityTokenFileCredentialsProvi

[incubator-pinot] branch master updated (c859044 -> 06e7ac6)

2021-06-03 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c859044 Modified the checkout scripts to parse arguments (#7011) add 06e7ac6 Merge/Rollup task executo

[GitHub] [incubator-pinot] snleee merged pull request #6975: Merge rollup executor enhancement

2021-06-03 Thread GitBox
snleee merged pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] snleee commented on pull request #6975: Merge rollup executor enhancement

2021-06-03 Thread GitBox
snleee commented on pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975#issuecomment-854092399 LGTM. Thanks for addressing all the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-pinot] branch master updated (fdef9bd -> c859044)

2021-06-03 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from fdef9bd Extract duplicate code in testSelectionOrderByAgoFunction into a single private helper function

[GitHub] [incubator-pinot] mcvsubbu merged pull request #7011: Modified the checkout scripts to parse arguments

2021-06-03 Thread GitBox
mcvsubbu merged pull request #7011: URL: https://github.com/apache/incubator-pinot/pull/7011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7011: Modified the checkout scripts to parse arguments

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #7011: URL: https://github.com/apache/incubator-pinot/pull/7011#issuecomment-853492562 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7011?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6998: Support json path expressions in query.

2021-06-03 Thread GitBox
codecov-commenter edited a comment on pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#issuecomment-852478013 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6998?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #7014: Add HLL++ support for better accuracy and possibly lower memory cost

2021-06-03 Thread GitBox
Jackie-Jiang commented on issue #7014: URL: https://github.com/apache/incubator-pinot/issues/7014#issuecomment-854037997 Another alternative is the Data Sketch HLL: https://datasketches.apache.org/docs/HLL/HLL.html They claim better performance in this paper: https://datasketches.apach

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7011: Modified the checkout scripts to parse arguments

2021-06-03 Thread GitBox
jackjlli commented on a change in pull request #7011: URL: https://github.com/apache/incubator-pinot/pull/7011#discussion_r644941547 ## File path: compatibility-verifier/utils.inc ## @@ -0,0 +1,12 @@ +#compute absolute path from a relative path Review comment: nit: put

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #7011: Modified the checkout scripts to parse arguments

2021-06-03 Thread GitBox
mcvsubbu commented on pull request #7011: URL: https://github.com/apache/incubator-pinot/pull/7011#issuecomment-853986294 @mqliang I updated the README and also pulled common function out to a different file. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] KKcorps opened a new pull request #7016: Add integration test for Kinesis realtime connector

2021-06-03 Thread GitBox
KKcorps opened a new pull request #7016: URL: https://github.com/apache/incubator-pinot/pull/7016 ## Description The PR addresses the issue #6992. It adds integration test for new Kinesis plugin. The input data file has been kept small deliberately as local kinesis by localstack doesn

[GitHub] [incubator-pinot] daniellavoie opened a new issue #7015: PinotOutputFormatTest.testPinotOutputFormat fails with java.lang.NoSuchMethodError

2021-06-03 Thread GitBox
daniellavoie opened a new issue #7015: URL: https://github.com/apache/incubator-pinot/issues/7015 Our internal CI picked up a consistent regression with the `PinotOutputFormatTest` from pinot-hadoop. The build is running using docker image `3.6.3-adoptopenjdk-8` and running the with

[GitHub] [incubator-pinot] lakshmanan-v opened a new issue #7014: Add HLL++ support for better accuracy and possibly lower memory cost

2021-06-03 Thread GitBox
lakshmanan-v opened a new issue #7014: URL: https://github.com/apache/incubator-pinot/issues/7014 DISTINCTCOUNTHLL accuracy and memory footprint can be improved through latest HLL algorithms. We have a choice either replace the existing implementation with a better one or leave the existin