Jackie-Jiang commented on a change in pull request #7019:
URL: https://github.com/apache/incubator-pinot/pull/7019#discussion_r645209309
##########
File path:
pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java
##########
@@ -40,21 +40,17 @@
import org.apache.http.util.EntityUtils;
import org.apache.pinot.spi.env.PinotConfiguration;
import org.apache.pinot.spi.environmentprovider.PinotEnvironmentProvider;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* Azure Environment Provider used to retrieve azure cloud specific instance
configuration.
*/
public class AzureEnvironmentProvider implements PinotEnvironmentProvider {
- private static final Logger LOGGER =
LoggerFactory.getLogger(AzureEnvironmentProvider.class);
-
protected static final String MAX_RETRY = "maxRetry";
protected static final String IMDS_ENDPOINT = "imdsEndpoint";
- protected static final String CONNECTION_TIMEOUT = "connectionTimeout";
- protected static final String REQUEST_TIMEOUT = "requestTimeout";
+ protected static final String CONNECTION_TIMEOUT_MILLIS =
"connectionTimeoutMillis";
+ protected static final String REQUEST_TIMEOUT_MILLIS =
"requestTimeoutMillis";
Review comment:
Seems we have both configs, so either way is fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
