Jackie-Jiang commented on a change in pull request #7013:
URL: https://github.com/apache/incubator-pinot/pull/7013#discussion_r645211296
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentMapper.java
##########
@@ -55,98 +59,113 @@
* - partitioning
*/
public class SegmentMapper {
-
private static final Logger LOGGER =
LoggerFactory.getLogger(SegmentMapper.class);
- private final File _inputSegment;
+
+ private final List<RecordReader> _recordReaders;
private final File _mapperOutputDir;
- private final String _mapperId;
- private final Schema _avroSchema;
- private final RecordTransformer _recordTransformer;
+ private final List<FieldSpec> _fieldSpecs;
+ private final boolean _includeNullFields;
+
+ // TODO: Merge the following transformers into one. Currently we need an
extra DataTypeTransformer in the end in case
+ // _recordTransformer changes the data type.
+ private final CompositeTransformer _defaultRecordTransformer;
private final RecordFilter _recordFilter;
- private final int _numPartitioners;
+ private final RecordTransformer _recordTransformer;
+ private final DataTypeTransformer _dataTypeTransformer;
+
private final List<Partitioner> _partitioners = new ArrayList<>();
- private final Map<String, DataFileWriter<GenericData.Record>>
_partitionToDataFileWriterMap = new HashMap<>();
+ private final Map<String, GenericRowFileManager> _partitionToFileManagerMap
= new HashMap<>();
- public SegmentMapper(String mapperId, File inputSegment, SegmentMapperConfig
mapperConfig, File mapperOutputDir) {
- _inputSegment = inputSegment;
+ public SegmentMapper(List<RecordReader> recordReaders, SegmentMapperConfig
mapperConfig, File mapperOutputDir) {
Review comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
