wuwenw commented on a change in pull request #6991:
URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r645271450
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderByMultiValueQueriesTest.java
##########
@@ -41,6 +42,43 @@ public void testGroupByOrderByMVSQLResults(String query,
List<Object[]> expected
expectedResults, expectedResults.size(), expectedDataSchema);
}
+ /**
+ * Tests the in-segment trim option for GroupBy OrderBy query
+ */
+ @Test(dataProvider = "orderByDataProvider")
+ public void testGroupByOrderByMVTrimOptLowLimitSQLResults(String query,
List<Object[]> expectedResults,
+ long expectedNumEntriesScannedPostFilter, DataSchema expectedDataSchema)
{
+
+ expectedResults = expectedResults.subList(0, expectedResults.size() / 2);
Review comment:
This test aims to trigger the in-segment trim by providing a low limit
number and a low trimSize, so the size of intermediateResult is greater than
max(5*limit, trimSize). intermediateResult will be trimmed by the in-segment
trim feature and then a limit will be applied (this is unavoidable). Still, we
can test to see if everything works in the in-segment trim phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
