apucher commented on a change in pull request #7010:
URL: https://github.com/apache/incubator-pinot/pull/7010#discussion_r645170448
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java
##########
@@ -79,7 +79,7 @@
*/
public abstract class ClusterTest extends ControllerTest {
private static final Logger LOGGER =
LoggerFactory.getLogger(ClusterTest.class);
- private static final int DEFAULT_BROKER_PORT = 18099;
+ protected static final int DEFAULT_BROKER_PORT = 18099;
Review comment:
see above
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java
##########
@@ -196,6 +217,24 @@ protected void startServers(int numServers,
PinotConfiguration configuration, in
}
}
+ protected void startServerHttps() {
+ FileUtils.deleteQuietly(new File(Server.DEFAULT_INSTANCE_BASE_DIR));
+ _serverStarters = new ArrayList<>();
+
+ Map<String, Object> properties = getDefaultServerConfiguration().toMap();
+
+ PinotConfiguration configuration = new PinotConfiguration(properties);
+ overrideServerConf(configuration);
Review comment:
turns out the test code already sets default values for pinot server in
involved ways. imo pinot's test code should be cleaned up, but that's another
story
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java
##########
@@ -64,6 +65,7 @@ public static void init(PinotConfiguration uploaderConfig) {
_sslContext = new
ClientSSLContextGenerator(httpsConfig.subset(CommonConstants.PREFIX_OF_SSL_SUBSET)).generate();
_controllerHttpsPort =
httpsConfig.getProperty(CONFIG_OF_CONTROLLER_HTTPS_PORT, Integer.class);
}
+ _protocol = uploaderConfig.getProperty(CONFIG_OF_PROTOCOL, HTTP_PROTOCOL);
Review comment:
unfortunately, the way `ServerSegmentCompletionProtocolHandler` is
written and used, there's no sane way to pass "non-specific" configs. Afaik
LinkedIn has some internal dependencies on this behavior, so I can't change it
either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
