[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6935: fixed UI crashing when server or brokers are offline

2021-05-20 Thread GitBox
codecov-commenter edited a comment on pull request #6935: URL: https://github.com/apache/incubator-pinot/pull/6935#issuecomment-845690290 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636667636 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6935: fixed UI crashing when server or brokers are offline

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6935: URL: https://github.com/apache/incubator-pinot/pull/6935#issuecomment-845690290 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6957: Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6957: URL: https://github.com/apache/incubator-pinot/pull/6957#issuecomment-845689733 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] shahsank3t closed pull request #6934: fixed showing all pinot servers in tenant details

2021-05-20 Thread GitBox
shahsank3t closed pull request #6934: URL: https://github.com/apache/incubator-pinot/pull/6934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6957: Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates

2021-05-20 Thread GitBox
kishoreg commented on a change in pull request #6957: URL: https://github.com/apache/incubator-pinot/pull/6957#discussion_r636652258 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/MergeEqInFilterOptimizer.java ## @@ -151,7 +150,7 @@ private

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636659687 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6956: fixed Pinot ui can't show all the pinot servers

2021-05-20 Thread GitBox
codecov-commenter edited a comment on pull request #6956: URL: https://github.com/apache/incubator-pinot/pull/6956#issuecomment-845678045 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6951: Update JSON datatype test cases + minor JSON index bug fix.

2021-05-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #6951: URL: https://github.com/apache/incubator-pinot/pull/6951#discussion_r636657483 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java ## @@

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6956: fixed Pinot ui can't show all the pinot servers

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6956: URL: https://github.com/apache/incubator-pinot/pull/6956#issuecomment-845678045 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636653733 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java ## @@ -43,7 +43,7 @@

[incubator-pinot] branch master updated (16f94a1 -> 5188d4e)

2021-05-20 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 16f94a1 Rename some complex type configs (#6953) add 5188d4e Add NETTY_CONNECTION_SEND_REQUEST_LA

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia merged pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6957: Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates

2021-05-20 Thread GitBox
Jackie-Jiang opened a new pull request #6957: URL: https://github.com/apache/incubator-pinot/pull/6957 ## Description Solve #6910 Add `TimePredicateFilterOptimizer` to optimize TIME_CONVERT/DATE_TIME_CONVERT function with range/equality predicate to directly apply the predicate

[GitHub] [incubator-pinot] shahsank3t closed pull request #6935: fixed UI crashing when server or brokers are offline

2021-05-20 Thread GitBox
shahsank3t closed pull request #6935: URL: https://github.com/apache/incubator-pinot/pull/6935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#issuecomment-845664511 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6936?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] shahsank3t commented on issue #6948: Pinot ui can't show all the pinot servers

2021-05-20 Thread GitBox
shahsank3t commented on issue #6948: URL: https://github.com/apache/incubator-pinot/issues/6948#issuecomment-845660396 @cxing @xiangfu0 PR raised: https://github.com/apache/incubator-pinot/pull/6956 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #6956: fixed Pinot ui can't show all the pinot servers

2021-05-20 Thread GitBox
shahsank3t opened a new pull request #6956: URL: https://github.com/apache/incubator-pinot/pull/6956 ## Description This PR fixes https://github.com/apache/incubator-pinot/issues/6948 ![image](https://user-images.githubusercontent.com/6761317/119085611-b0554f00-ba21-11eb-92cb-60c4

[incubator-pinot] branch add-two-broker-metrics updated (f037422 -> 9dc309a)

2021-05-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-two-broker-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f037422 Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics add 9dc309a

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636631845 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -50,6 +51,14 @@ public int getSubmitDela

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636626870 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -50,6 +51,14 @@ public int getSubmitDela

[incubator-pinot] branch add-two-broker-metrics updated (7537984 -> f037422)

2021-05-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-two-broker-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7537984 Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics add f037422

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636622553 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java ## @@ -73,7 +73,7 @@ public AsyncQueryResp

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636622401 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -69,13 +78,18 @@ public int getDeseriali

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636622401 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -69,13 +78,18 @@ public int getDeseriali

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6949: SegmentDirectoryLoader interface and local impl

2021-05-20 Thread GitBox
codecov-commenter edited a comment on pull request #6949: URL: https://github.com/apache/incubator-pinot/pull/6949#issuecomment-845620747 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6955: UDF argument type matching

2021-05-20 Thread GitBox
siddharthteotia commented on issue #6955: URL: https://github.com/apache/incubator-pinot/issues/6955#issuecomment-845622500 +1 When this came up in our offline discussions with you and @amrishlal , we had discussed compile time code generation of java classes using templates as oppose

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6949: SegmentDirectoryLoader interface and local impl

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6949: URL: https://github.com/apache/incubator-pinot/pull/6949#issuecomment-845620747 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #6955: UDF argument type matching

2021-05-20 Thread GitBox
Jackie-Jiang opened a new issue #6955: URL: https://github.com/apache/incubator-pinot/issues/6955 In `FunctionRegistry`, the UDFs annotated with `ScalarFunction` are registered based on the function name and the number of arguments. In addition to that, we should also allow registering mul

[GitHub] [incubator-pinot] Jackie-Jiang closed issue #6700: Throw exception and give error message when creating schema with spaces in column name

2021-05-20 Thread GitBox
Jackie-Jiang closed issue #6700: URL: https://github.com/apache/incubator-pinot/issues/6700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636568340 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636567153 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636562831 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636562607 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636562412 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -603,6 +6

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636561961 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636561374 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -122,6 +1

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-20 Thread GitBox
chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r636561303 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -122,6 +1

[incubator-pinot] branch add-two-broker-metrics updated (0fc2da3 -> 7537984)

2021-05-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-two-broker-metrics in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0fc2da3 Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics discard 008a925

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636523494 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -50,6 +51,14 @@ public int getSubmitDelayMs() {

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
jackjlli commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636520969 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java ## @@ -29,7 +29,9 @@ // metric tracking the freshne

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636520327 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java ## @@ -29,7 +29,9 @@ // metric tracking the

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636519978 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -50,6 +51,14 @@ public int getSubmitDela

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636519362 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java ## @@ -50,6 +51,14 @@ public int getSubmitDela

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6936: URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636519034 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java ## @@ -144,7 +148,12 @@ synchronized void send

[incubator-pinot] branch master updated: Rename some complex type configs (#6953)

2021-05-20 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 16f94a1 Rename some complex type confi

[GitHub] [incubator-pinot] yupeng9 merged pull request #6953: Rename some complex type configs

2021-05-20 Thread GitBox
yupeng9 merged pull request #6953: URL: https://github.com/apache/incubator-pinot/pull/6953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6953: Rename some complex type configs

2021-05-20 Thread GitBox
codecov-commenter edited a comment on pull request #6953: URL: https://github.com/apache/incubator-pinot/pull/6953#issuecomment-845516740 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #5446: Make Pinot Broker/Server/Minion can start by just passing a config file

2021-05-20 Thread GitBox
xiangfu0 commented on a change in pull request #5446: URL: https://github.com/apache/incubator-pinot/pull/5446#discussion_r636512691 ## File path: pinot-tools/src/main/resources/conf/pinot-broker.conf ## @@ -0,0 +1,33 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[incubator-pinot] branch master updated (f4ae3e0 -> d63d6c5)

2021-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f4ae3e0 Add collectionToJsonMode to schema inference (#6946) add d63d6c5 Fix NPE issue when consumed

[GitHub] [incubator-pinot] xiangfu0 merged pull request #6950: Filter out null value in Kafka Message when construct message batch

2021-05-20 Thread GitBox
xiangfu0 merged pull request #6950: URL: https://github.com/apache/incubator-pinot/pull/6950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6953: Rename some complex type configs

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6953: URL: https://github.com/apache/incubator-pinot/pull/6953#issuecomment-845516740 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5446: Make Pinot Broker/Server/Minion can start by just passing a config file

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #5446: URL: https://github.com/apache/incubator-pinot/pull/5446#issuecomment-845514923 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6950: Filter out null value in Kafka Message when construct message batch

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6950: URL: https://github.com/apache/incubator-pinot/pull/6950#issuecomment-845481327 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6951: Update JSON datatype test cases + minor JSON index bug fix.

2021-05-20 Thread GitBox
codecov-commenter commented on pull request #6951: URL: https://github.com/apache/incubator-pinot/pull/6951#issuecomment-845474729 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6951?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] mayankshriv closed issue #6952: Non-intuitive response from query execution when broker for table not found

2021-05-20 Thread GitBox
mayankshriv closed issue #6952: URL: https://github.com/apache/incubator-pinot/issues/6952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] mayankshriv commented on issue #6952: Non-intuitive response from query execution when broker for table not found

2021-05-20 Thread GitBox
mayankshriv commented on issue #6952: URL: https://github.com/apache/incubator-pinot/issues/6952#issuecomment-845443675 This was already addressed in https://github.com/apache/incubator-pinot/pull/6765. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6954: Replace error code name to be more readable.

2021-05-20 Thread GitBox
mayankshriv commented on pull request #6954: URL: https://github.com/apache/incubator-pinot/pull/6954#issuecomment-845437822 Apparently this was already addressed in a previous PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-pinot] mayankshriv closed pull request #6954: Replace error code name to be more readable.

2021-05-20 Thread GitBox
mayankshriv closed pull request #6954: URL: https://github.com/apache/incubator-pinot/pull/6954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #6954: Replace error code name to be more readable.

2021-05-20 Thread GitBox
mayankshriv opened a new pull request #6954: URL: https://github.com/apache/incubator-pinot/pull/6954 One of the common mistakes that happen when using query console is to mis-type table name in query. Today it leads to a cryptic error message `BrokerResourceMissing`. Changing the

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6953: Rename some complex type configs

2021-05-20 Thread GitBox
yupeng9 opened a new pull request #6953: URL: https://github.com/apache/incubator-pinot/pull/6953 Part of https://github.com/apache/incubator-pinot/issues/6904 ## Description Rename `ComplexTypeConfig. unnestFields ` to `ComplexTypeConfig. fieldsToUnnest ` and `ComplexTypeC

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (fe5527c -> 548eba4)

2021-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fe5527c Make Pinot Broker/Server/Minion can start by just passing a

[GitHub] [incubator-pinot] jackjlli commented on pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-20 Thread GitBox
jackjlli commented on pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#issuecomment-845358143 > I'd strongly recommend short circuit the query on broker without sending it to servers. On server side all segments will be pruned and the result will be the same as

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6942: Detect invalid column names from SQL query in BrokerRequestHandler

2021-05-20 Thread GitBox
jackjlli commented on a change in pull request #6942: URL: https://github.com/apache/incubator-pinot/pull/6942#discussion_r636348514 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -1682,6 +1685,74 @@ static v

[incubator-pinot] branch detect-invalid-columns updated (81653d8 -> 8794600)

2021-05-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch detect-invalid-columns in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 81653d8 Detect invalid column names from BrokerRequestHandler add e400566 Add the compl

[incubator-pinot] branch detect-invalid-columns updated (21fc475 -> 81653d8)

2021-05-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch detect-invalid-columns in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 21fc475 Detect invalid column names from BrokerRequestHandler add 98891a3 Fix rules to

[GitHub] [incubator-pinot] mayankshriv opened a new issue #6952: Non-intuitive response from query execution when broker for table not found

2021-05-20 Thread GitBox
mayankshriv opened a new issue #6952: URL: https://github.com/apache/incubator-pinot/issues/6952 When a broker for a table in the query is not found, the error returned to the user is cryptic and non-intuitive; ``` {'errorCode': 410, 'message': 'BrokerResourceMissingError'} ```

[GitHub] [incubator-pinot] amrishlal opened a new pull request #6951: Update JSON datatype test cases + minor JSON index bug fix.

2021-05-20 Thread GitBox
amrishlal opened a new pull request #6951: URL: https://github.com/apache/incubator-pinot/pull/6951 ## Description Update JSON datatype test cases + minor JSON index bug fix (use stored type instead of derived type) ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (A

[incubator-pinot] branch master updated: Add collectionToJsonMode to schema inference (#6946)

2021-05-20 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new f4ae3e0 Add collectionToJsonMode to sc

[incubator-pinot] branch master updated: Add the complex-type support to decoder/reader (#6945)

2021-05-20 Thread yupeng
This is an automated email from the ASF dual-hosted git repository. yupeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e400566 Add the complex-type support t

[GitHub] [incubator-pinot] yupeng9 merged pull request #6946: Add collectionToJsonMode to schema inference

2021-05-20 Thread GitBox
yupeng9 merged pull request #6946: URL: https://github.com/apache/incubator-pinot/pull/6946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] yupeng9 merged pull request #6945: Add the complex-type support to decoder/reader

2021-05-20 Thread GitBox
yupeng9 merged pull request #6945: URL: https://github.com/apache/incubator-pinot/pull/6945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636275572 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java ## @@ -76,18 +77,28 @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636270444 ## File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java ## @@ -373,6 +374,15 @@ public void tes

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636269616 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -353,38 +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636268275 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -353,38 +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636267143 ## File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java ## @@ -1690,6 +1700,23 @@ public void t

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636266362 ## File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java ## @@ -1690,6 +1700,23 @@ public void t

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-20 Thread GitBox
siddharthteotia commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636266028 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java ## @@ -76,18 +77,28 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6950: Fix NPE issue when consumed kafka message is null or the record value is null

2021-05-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #6950: URL: https://github.com/apache/incubator-pinot/pull/6950#discussion_r636209942 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaMessageBatch.java #

[GitHub] [incubator-pinot] xiangfu0 opened a new pull request #6950: Fix NPE issue when consumed kafka message is null or the record value is null

2021-05-20 Thread GitBox
xiangfu0 opened a new pull request #6950: URL: https://github.com/apache/incubator-pinot/pull/6950 ## Description Current Pinot Kafka consumption will stop and cannot recover when there is a null message in the topic. Adding the logic to skip the null value and move on. ##

[GitHub] [incubator-pinot] troywinter commented on issue #6910: Segment Pruning is not happening when filtering transformed timecolumn

2021-05-20 Thread GitBox
troywinter commented on issue #6910: URL: https://github.com/apache/incubator-pinot/issues/6910#issuecomment-844849550 One thing that Druid did right I think is separating datetime transform with time bucketing, timefloor function will only convert the time column by a period, it doesn't