[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6936: Add NETTY_CONNECTION_SEND_REQUEST_LATENCY to broker timer metrics

[GitBox]

siddharthteotia commented on a change in pull request #6936:
URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636622401



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
##########
@@ -69,13 +78,18 @@ public int getDeserializationTimeMs() {
   @Override
   public String toString() {
     return String
-        .format("%d,%d,%d,%d", getSubmitDelayMs(), getResponseDelayMs(), 
getResponseSize(), getDeserializationTimeMs());
+        .format("%d,%d,%d,%d,%d", getSubmitDelayMs(), getRequestSentDelayMs(), 
getResponseDelayMs(), getResponseSize(),

Review comment:
       better to add new metric at the end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org