[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6820: Add ago() scalar transform function

[GitBox]

siddharthteotia commented on a change in pull request #6820:
URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r636266028



##########
File path: 
pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java
##########
@@ -76,18 +77,28 @@ public void testNumberLiteralBrokerRequestFromSQL() {
   public void testLiteralOnlyTransformBrokerRequestFromSQL() {
     Assert
         
.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser.compileToPinotQuery("SELECT
 now()")));
+    Assert.assertTrue(
+        
BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser.compileToPinotQuery("SELECT
 ago('PT1H')")));
     Assert.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(
         CalciteSqlParser.compileToPinotQuery("SELECT now(), 
fromDateTime('2020-01-01 UTC', 'yyyy-MM-dd z')")));
+    Assert.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(
+        CalciteSqlParser.compileToPinotQuery("SELECT ago('PT1H'), 
fromDateTime('2020-01-01 UTC', 'yyyy-MM-dd z')")));
     Assert.assertTrue(
         
BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser.compileToPinotQuery("SELECT
 now() FROM myTable")));
+    Assert.assertTrue(BaseBrokerRequestHandler
+        .isLiteralOnlyQuery(CalciteSqlParser.compileToPinotQuery("SELECT 
ago('PT1H') FROM myTable")));
     
Assert.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser
         .compileToPinotQuery("SELECT now(), fromDateTime('2020-01-01 UTC', 
'yyyy-MM-dd z') FROM myTable")));
+    
Assert.assertTrue(BaseBrokerRequestHandler.isLiteralOnlyQuery(CalciteSqlParser
+        .compileToPinotQuery("SELECT ago('PT1H'), fromDateTime('2020-01-01 
UTC', 'yyyy-MM-dd z') FROM myTable")));

Review comment:
       Can we add a test that the following query returns false for 
isLiteralOnlyQuery ?
   
   `SELECT count(*) from foo where timestamp > ago(1h) ?`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org