siddharthteotia commented on a change in pull request #6936:
URL: https://github.com/apache/incubator-pinot/pull/6936#discussion_r636626870
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
##########
@@ -50,6 +51,14 @@ public int getSubmitDelayMs() {
}
}
+ public int getRequestSentDelayMs() {
+ if (_sendRequestTimeMs != 0) {
+ return (int) (_sendRequestTimeMs - _startTimeMs);
+ } else {
+ return -1;
+ }
Review comment:
@jackjlli , this seems incorrect. this is for time it took to send
request on transport so although you are emitting in the metrics correctly ,
here since the delta is computed from start time, it gets recorded incorrectly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
