[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291028808 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResource

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291028834 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java ##

[incubator-pinot] branch create-lead-controller-resource updated (b05ff27 -> 1e58963)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit b05ff27 Address PR comments add 1e58963 Address PR comments This update added

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291028704 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResource

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291024996 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] codecov-io commented on issue #4284: Put managing Pinot under in_production

codecov-io commented on issue #4284: Put managing Pinot under in_production URL: https://github.com/apache/incubator-pinot/pull/4284#issuecomment-499342153 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4284?src=pr&el=h1) Report > Merging [#4284](https://codecov.io/gh/ap

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291014208 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291014341 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291013867 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java ###

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291015024 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291014544 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291014830 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291012662 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291012552 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291013273 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291013572 ## File path: pinot-core/src/test/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291012862 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291013339 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291012712 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

codecov-io edited a comment on issue #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#issuecomment-497997586 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3934?src=pr&el=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290995380 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/transform/Tran

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r29099 ## File path: pinot-common/pom.xml ## @@ -371,6 +371,13 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290997224 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/transform/Tran

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290998963 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290998512 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290999470 ## File path: pinot-core/src/test/java/org/apache/pinot/reduce/HavingClauseComparisonTe

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291011687 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/RegexpLi

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r29071 ## File path: pinot-common/src/thrift/query.thrift ## @@ -0,0 +1,77 @@ +/** +

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291000710 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/RegexpLi

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291000420 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAs

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290995127 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestU

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291011976 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/Predicat

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291012295 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/InPredic

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291000590 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/SelectAs

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r291012177 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/InPredic

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290999849 ## File path: pinot-common/src/thrift/query.thrift ## @@ -0,0 +1,77 @@ +/** +

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290990600 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/transform/Tran

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290999378 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKi

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290995596 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/transform/Tran

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290997578 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290998454 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290997976 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r290998808 ## File path: pinot-common/src/main/java/org/apache/pinot/pql/parsers/Pql2Compiler.java

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4284: Put managing Pinot under in_production

jackjlli opened a new pull request #4284: Put managing Pinot under in_production URL: https://github.com/apache/incubator-pinot/pull/4284 This PR puts `managing Pinot` under `in_production` page. This is an automated message f

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291009874 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291009909 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291000434 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster

codecov-io edited a comment on issue #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#issuecomment-479147030 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4047?src=pr&el=h1) Report > Merging [#4047](https://

[incubator-pinot] branch create-lead-controller-resource updated (cf17be2 -> b05ff27)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard cf17be2 Address PR comments discard 01a0dee Separate Helix cluster creation logic

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290993836 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290993794 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java #

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290993821 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[incubator-pinot] branch create-lead-controller-resource updated (25a482a -> cf17be2)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 25a482a Address PR comments add cf17be2 Address PR comments This update added

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290991635 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290990765 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290990502 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResource

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290990476 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResource

[incubator-pinot] branch create-lead-controller-resource updated (76d491b -> 25a482a)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch create-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 76d491b Address PR comments omit cdb30e9 Separate Helix cluster creation logic

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290990196 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResource

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

Jackie-Jiang commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-499310687 @fx19880617 I just reformatted all thrift auto-generated files in #4283. Can you rebase the branch on master, and

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4283: Reformat classes in pinot-common

Jackie-Jiang merged pull request #4283: Reformat classes in pinot-common URL: https://github.com/apache/incubator-pinot/pull/4283 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pinot] branch auto_reformat deleted (was 18946af)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch auto_reformat in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 18946af Reformat classes in pinot-common The revisions that were on this branch are still contained

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290987165 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290988482 ## File path: pinot-core/src/test/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290987784 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290986737 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290986799 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290985375 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290987487 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290986874 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/fu

[incubator-pinot] branch master updated: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests (#4278)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8ffa381 Add OfflineSegmentIntervalCheck

[GitHub] [incubator-pinot] snleee merged pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

snleee merged pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-pinot] codecov-io commented on issue #4283: Reformat classes in pinot-common

codecov-io commented on issue #4283: Reformat classes in pinot-common URL: https://github.com/apache/incubator-pinot/pull/4283#issuecomment-499305868 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4283?src=pr&el=h1) Report > Merging [#4283](https://codecov.io/gh/apache/i

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4253: Add segment pre-processing Hadoop job

codecov-io edited a comment on issue #4253: Add segment pre-processing Hadoop job URL: https://github.com/apache/incubator-pinot/pull/4253#issuecomment-497205230 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4253?src=pr&el=h1) Report > Merging [#4253](https://codecov.i

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

codecov-io edited a comment on issue #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278#issuecomment-498560034 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4278?src=pr&el=h1) Report > Mergi

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

codecov-io edited a comment on issue #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278#issuecomment-498560034 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4278?src=pr&el=h1) Report > Mergi

[incubator-pinot] branch auto_reformat updated (c3fbd32 -> 18946af)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch auto_reformat in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c3fbd32 Reformat classes in pinot-common add 18946af Reformat classes in pinot-common This up

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290974769 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290969443 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290974226 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290970805 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290971658 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290973261 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290970490 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290975030 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290973015 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290969374 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290971361 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290968663 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java #

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster

Jackie-Jiang commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290970130 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixReso

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

npawar commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278#discussion_r290975117 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tes

[GitHub] [incubator-pinot] snleee commented on issue #4283: Reformat classes in pinot-common

snleee commented on issue #4283: Reformat classes in pinot-common URL: https://github.com/apache/incubator-pinot/pull/4283#issuecomment-499287761 This pr is a good example for the issue raised in https://github.com/apache/incubator-pinot/issues/4264

[incubator-pinot] branch auto_reformat updated (3a8521d -> c3fbd32)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch auto_reformat in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 3a8521d Reformat classes in pinot-common add c3fbd32 Reformat classes in pinot-common This up

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4283: Reformat classes in pinot-common

Jackie-Jiang opened a new pull request #4283: Reformat classes in pinot-common URL: https://github.com/apache/incubator-pinot/pull/4283 Includes thrift auto-generated files. Auto-generated files from different Thrift version have different format. Keep thrift files following Pinot

[incubator-pinot] branch auto_reformat created (now 3a8521d)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch auto_reformat in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 3a8521d Reformat classes in pinot-common This branch includes the following new commits: new

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

snleee commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278#discussion_r290966599 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tes

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4282: update currentAnomalies to read new selectedRule object

xiaohui-sun merged pull request #4282: update currentAnomalies to read new selectedRule object URL: https://github.com/apache/incubator-pinot/pull/4282 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch master updated: update currentAnomalies to read new selectedRule object (#4282)

This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 752196c update currentAnomalies to read

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4282: update currentAnomalies to read new selectedRule object

harleyjj opened a new pull request #4282: update currentAnomalies to read new selectedRule object URL: https://github.com/apache/incubator-pinot/pull/4282 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests

snleee commented on a change in pull request #4278: Add OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests URL: https://github.com/apache/incubator-pinot/pull/4278#discussion_r290954006 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tes

  1   2   >