Jackie-Jiang commented on a change in pull request #3934: support 
abs,ceil,exp,floor,ln,log,sqrt math transform function
URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r291013572
 
 

 ##########
 File path: 
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunctionTest.java
 ##########
 @@ -87,7 +87,7 @@ public void setUp()
       _intSVValues[i] = RANDOM.nextInt();
       _longSVValues[i] = RANDOM.nextLong();
       _floatSVValues[i] = RANDOM.nextFloat();
-      _doubleSVValues[i] = RANDOM.nextDouble();
+      _doubleSVValues[i] = _intSVValues[i] * RANDOM.nextDouble();
 
 Review comment:
   Can you also change floatSV and stringSV so they are consistent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to