Jackie-Jiang commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290971361
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2380,6 +2398,16 @@ public boolean isSingleTenantCluster() {
return endpointToInstance;
}
+ public IdealState getLeadControllerResourceIdealState() {
Review comment:
I understand. My question is, should we keep these two methods in the
resource manager (IMO they are not very related to the resource manager), or
directly use helix admin to fetch them (same as table resource and broker
resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
