Jackie-Jiang commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290970805
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -260,19 +268,32 @@ public HelixAdmin getHelixAdmin() {
*/
private HelixManager registerAndConnectAsHelixParticipant() {
HelixManager helixManager = HelixManagerFactory
- .getZKHelixManager(_helixClusterName,
CommonConstants.Helix.PREFIX_OF_CONTROLLER_INSTANCE + _instanceId,
- InstanceType.PARTICIPANT, _helixZkURL);
+ .getZKHelixManager(_helixClusterName,
_controllerParticipantInstanceId, InstanceType.PARTICIPANT, _helixZkURL);
+
+ StateMachineEngine stateMach = helixManager.getStateMachineEngine();
Review comment:
Line 273-275 can be merged into one line, and please add some comments for
this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
