Jackie-Jiang commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r291013867
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java
##########
@@ -45,18 +46,20 @@ public static boolean hasValidServerTagSuffix(String
tagName) {
return false;
}
- public static TenantRole getTenantRoleFromTag(String tagName)
- throws InvalidConfigException {
- if (tagName.endsWith(ServerType.REALTIME.toString())) {
- return TenantRole.SERVER;
- }
- if (tagName.endsWith(ServerType.OFFLINE.toString())) {
- return TenantRole.SERVER;
- }
- if (tagName.endsWith(TenantRole.BROKER.toString())) {
- return TenantRole.BROKER;
- }
- throw new InvalidConfigException("Cannot identify tenant type from tag
name : " + tagName);
+ public static boolean isServerTag(String tagName) {
+ return isOfflineServerTag(tagName) || isRealtimeServerTag(tagName);
+ }
+
+ public static boolean isOfflineServerTag(String tagName) {
+ return tagName.endsWith(ServerType.OFFLINE.toString());
+ }
+
+ public static boolean isRealtimeServerTag(String tagName) {
+ return tagName.endsWith(ServerType.REALTIME.toString());
+ }
+
+ public static boolean isBrokerTags(String tagName) {
Review comment:
isBrokerTag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
