[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
codecov-io edited a comment on issue #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#issuecomment-494654304 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4229?src=pr&el=h1) Report

[incubator-pinot] branch master updated: Emit freshnessLag metric from broker for queries hitting consuming segments (#4229)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 06baad6 Emit freshnessLag metri

[incubator-pinot] branch consumingStats deleted (was 704b346)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 704b346 Minor formatting fixes The revisions that were on this branch are still contained i

[GitHub] [incubator-pinot] sunithabeeram merged pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
sunithabeeram merged pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229 This is an automated message from the Apache Git S

[GitHub] [incubator-pinot] codecov-io commented on issue #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
codecov-io commented on issue #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#issuecomment-494654304 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4229?src=pr&el=h1) Report > Mer

[incubator-pinot] branch consumingStats updated (e6b9b59 -> 704b346)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e6b9b59 Address review comments add 704b346 Minor formatting fixes No new revisions w

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286311492 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/sc

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286311371 ## File path: pinot-common/src/main/java/org/apache/pinot/common/resp

[incubator-pinot] branch consumingStats updated (788e7cc -> e6b9b59)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 788e7cc Emit freshnessLag metric from broker for queries hitting consuming segments ad

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
sunithabeeram commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286309018 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/e

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang merged pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: Add startup/shutdown checks for HelixServerStarter (#4222)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8a0b8ce Add startup/shutdown checks fo

[incubator-pinot] branch server_restart deleted (was 2122dbf)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_restart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 2122dbf Address comments The revisions that were on this branch are still contained in other refer

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-493717771 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4222?src=pr&el=h1) Report > Merging [#4222](http

[incubator-pinot] branch server_restart updated (fbe7181 -> 2122dbf)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_restart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fbe7181 Address comments add 2122dbf Address comments This update added new revisions after

[GitHub] [incubator-pinot] cecilynie commented on a change in pull request #4212: [TE] Grouper Interface - Group/Summarize Metric level anomalies

2019-05-21 Thread GitBox
cecilynie commented on a change in pull request #4212: [TE] Grouper Interface - Group/Summarize Metric level anomalies URL: https://github.com/apache/incubator-pinot/pull/4212#discussion_r286290245 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detect

[GitHub] [incubator-pinot] cecilynie commented on a change in pull request #4212: [TE] Grouper Interface - Group/Summarize Metric level anomalies

2019-05-21 Thread GitBox
cecilynie commented on a change in pull request #4212: [TE] Grouper Interface - Group/Summarize Metric level anomalies URL: https://github.com/apache/incubator-pinot/pull/4212#discussion_r286291082 ## File path: thirdeye/thirdeye-pinot/src/test/resources/org/apache/pinot/thirdeye/d

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-494624812 > Just remembered one thing that might be good to keep in mind: the reason a shutdown resource check was added was to ha

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
sunithabeeram commented on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-494615947 Just remembered one thing that might be good to keep in mind: the reason a shutdown resource check was added was to han

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286276194 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requ

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286278573 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/re

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286277086 ## File path: pinot-common/src/main/java/org/apache/pinot/common/resp

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286276815 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286278352 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/ex

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286279133 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/re

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4231: Bounds

2019-05-21 Thread GitBox
harleyjj opened a new pull request #4231: Bounds URL: https://github.com/apache/incubator-pinot/pull/4231 1) Adds confidence bounds to graph in Preview when Predicted baseline is selected 2) Adds spinner to graph when updating baseline only (Preview and Alert Overview) 3) Makes time

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494609408 Discussed with @kishoreg offline. Will hold on this PR and see how much effort it tak

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-493717771 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4222?src=pr&el=h1) Report > Merging [#4222](http

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-494600143 @sunithabeeram Updated the PR description for the behavior changes.

[incubator-pinot] branch server_restart updated (40d1c1f -> fbe7181)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_restart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 40d1c1f Address comments add fbe7181 Address comments This update added new revisions after

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286263074 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[incubator-pinot] branch server_restart updated (3d5c5fc -> 40d1c1f)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_restart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3d5c5fc Address comments add 40d1c1f Address comments This update added new revisions after

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494596106 @kishoreg I understand that NULL value is per column, but for example: SELECT SUM(A),

[GitHub] [incubator-pinot] kishoreg commented on issue #3998: Upgrade to use Kafka release 2.1.1

2019-05-21 Thread GitBox
kishoreg commented on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-494584656 @npawar Is there a way to skip the initial steps of adding Fake stream? Let’s try to abstract the module first. We can keep the dependen

[GitHub] [incubator-pinot] kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494583232 NULL value is per column. Also, I think I now remember the discussion with Mayank. This w

[GitHub] [incubator-pinot] mcvsubbu commented on issue #3998: Upgrade to use Kafka release 2.1.1

2019-05-21 Thread GitBox
mcvsubbu commented on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-494582841 @ananthdurai can you contribute towards this effort (esp after step 2)?

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286249353 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #4230: NULL value support for all data types

2019-05-21 Thread GitBox
Jackie-Jiang opened a new issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230 Currently in Pinot we don't have real NULL value support, but use some special default values for NULL. For dimensions, the default value is the minimum v

[GitHub] [incubator-pinot] npawar edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1

2019-05-21 Thread GitBox
npawar edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-494581187 We're planning to work on this issue this quarter. We (@mcvsubbu and I) will do some refactoring, such that the kafka code will be

[GitHub] [incubator-pinot] npawar commented on issue #3998: Upgrade to use Kafka release 2.1.1

2019-05-21 Thread GitBox
npawar commented on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-494581187 We're planning to work on this issue this quarter. We (@mcvsubbu and I) will do some refactoring, such that the kafka code will be separat

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
codecov-io edited a comment on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-493717771 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4222?src=pr&el=h1) Report > Merging [#4222](http

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494578632 @kishoreg It cannot be done in filter phase because for each document, there is no gu

[GitHub] [incubator-pinot] kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494578331 Let’s create an issue for supporting null and point to this PR.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286244988 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread GitBox
sunithabeeram opened a new pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments URL: https://github.com/apache/incubator-pinot/pull/4229 This is the next (mostly last) of the implementation phase for freshness metric discussed in #4007. Th

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4217: [TE] distribute detection and notification tasks

2019-05-21 Thread GitBox
xiaohui-sun merged pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217 This is an automated message from the Apache Git Service. To respond to the mes

[incubator-pinot] branch master updated: [TE] distribute detection and notification tasks (#4217)

2019-05-21 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 866289c [TE] distribute detection and n

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4007: Improve/Add completeness and freshness metrics for Pinot

2019-05-21 Thread GitBox
sunithabeeram commented on issue #4007: Improve/Add completeness and freshness metrics for Pinot URL: https://github.com/apache/incubator-pinot/issues/4007#issuecomment-494562461 More formal discussion around tracking Freshness can be found here: https://cwiki.apache.org/confluence/displa

[incubator-pinot] branch server_restart updated (f91eaa3 -> 3d5c5fc)

2019-05-21 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_restart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f91eaa3 Address comment add 3d5c5fc Address comments No new revisions were added by this upd

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286224930 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286224262 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286223813 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286222848 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286222761 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286220659 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286215184 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286214279 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286213019 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4133: add more types parsing for string coerceValueIntoField

2019-05-21 Thread GitBox
Jackie-Jiang commented on a change in pull request #4133: add more types parsing for string coerceValueIntoField URL: https://github.com/apache/incubator-pinot/pull/4133#discussion_r286210953 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/Deserializer.java

[GitHub] [incubator-pinot] kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
kishoreg commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494508908 ok. It's better to support NULL as first-class instead of checking for NULL every row rig

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator

2019-05-21 Thread GitBox
Jackie-Jiang commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494505085 @kishoreg Yes, and we treat empty byte array as NULL for BYTES. -

[GitHub] [incubator-pinot] akshayrai merged pull request #4221: [TE] Code cleanup - Pull out all validation checks from translator into validator modules

2019-05-21 Thread GitBox
akshayrai merged pull request #4221: [TE] Code cleanup - Pull out all validation checks from translator into validator modules URL: https://github.com/apache/incubator-pinot/pull/4221 This is an automated message from the Ap

[incubator-pinot] branch master updated: [TE] Code cleanup - Pull out all validation checks from translator into validator modules (#4221)

2019-05-21 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3a37067 [TE] Code cleanup - Pull

[incubator-pinot] branch consumingStats updated (a5066fb -> 788e7cc)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a5066fb Emit freshnessLag metric from broker for queries hitting consuming segments ne

[incubator-pinot] 01/01: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a commit to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 788e7cc151e407d5e1c13f1da748b270e96d6aac Author: Sunitha Beeram AuthorDate: Tue May 21 10:55:51

[incubator-pinot] branch consumingStats created (now a5066fb)

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a change to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at a5066fb Emit freshnessLag metric from broker for queries hitting consuming segments This b

[incubator-pinot] 01/01: Emit freshnessLag metric from broker for queries hitting consuming segments

2019-05-21 Thread sunithabeeram
This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a commit to branch consumingStats in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit a5066fbe5ebd2e22311db4c37d818e8227e98d97 Author: Sunitha Beeram AuthorDate: Tue May 21 10:55:51

[GitHub] [incubator-pinot] npawar merged pull request #4226: Fix link for KafkaConsumerFactory in PluggableStreams doc

2019-05-21 Thread GitBox
npawar merged pull request #4226: Fix link for KafkaConsumerFactory in PluggableStreams doc URL: https://github.com/apache/incubator-pinot/pull/4226 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: Fix link for KafkaConsumerFactory in PluggableStreams doc (#4226)

2019-05-21 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 1bcfbb3 Fix link for KafkaConsumerF

[incubator-pinot] branch master updated: [TE] Fix MySql data source to read the epoch time stamps (#4227)

2019-05-21 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e1e79bf [TE] Fix MySql data source to r

[GitHub] [incubator-pinot] jihaozh merged pull request #4227: [TE] Fix MySql data source to read the epoch time stamps

2019-05-21 Thread GitBox
jihaozh merged pull request #4227: [TE] Fix MySql data source to read the epoch time stamps URL: https://github.com/apache/incubator-pinot/pull/4227 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch distribute_tasks updated (e26b461 -> dbbe697)

2019-05-21 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e26b461 [TE] Distribute job load to add random delays add dbbe697 [TE] Fix minor bug when lo

[GitHub] [incubator-pinot] kishoreg commented on issue #4219: Support SQL in Pinot.

2019-05-21 Thread GitBox
kishoreg commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-494469365 @Jackie-Jiang, yes once we migrate the execution layer to work on PinotQuery, we can definitely move over to PinotQuery if needed. The way I se

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4228: Fixing log issue for pinot-tools package

2019-05-21 Thread GitBox
snleee commented on a change in pull request #4228: Fixing log issue for pinot-tools package URL: https://github.com/apache/incubator-pinot/pull/4228#discussion_r286114045 ## File path: pinot-tools/src/main/resources/conf/pinot-tools-log4j2.xml ## @@ -21,11 +21,7 @@ -->

[GitHub] [incubator-pinot] snleee merged pull request #4228: Fixing log issue for pinot-tools package

2019-05-21 Thread GitBox
snleee merged pull request #4228: Fixing log issue for pinot-tools package URL: https://github.com/apache/incubator-pinot/pull/4228 This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-pinot] branch master updated: Fixing log issue for pinot-tools package (#4228)

2019-05-21 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 956df63 Fixing log issue for pinot-tool

[incubator-pinot] branch master updated: Adding a hash code partition function (#4220)

2019-05-21 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6b5b091 Adding a hash code partition fu

[GitHub] [incubator-pinot] snleee merged pull request #4220: Adding a simple partition function

2019-05-21 Thread GitBox
snleee merged pull request #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-21 Thread GitBox
akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r286112596 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPi

[GitHub] [incubator-pinot] kishoreg commented on issue #3899: [Parsing][PQL] Allow more than one dot in the identifier

2019-05-21 Thread GitBox
kishoreg commented on issue #3899: [Parsing][PQL] Allow more than one dot in the identifier URL: https://github.com/apache/incubator-pinot/pull/3899#issuecomment-494460413 @agrawaldevesh what do you want to do with this PR? T

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286099898 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286101047 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286099082 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286100316 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286098317 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286097130 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286092593 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4228: Fixing log issue for pinot-tools package

2019-05-21 Thread GitBox
mcvsubbu commented on a change in pull request #4228: Fixing log issue for pinot-tools package URL: https://github.com/apache/incubator-pinot/pull/4228#discussion_r286088811 ## File path: pinot-tools/src/main/resources/conf/pinot-tools-log4j2.xml ## @@ -21,11 +21,7 @@ -->

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
sunithabeeram commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286076909 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerSta

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
sunithabeeram commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286085295 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerSta

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4220: Adding a simple partition function

2019-05-21 Thread GitBox
codecov-io edited a comment on issue #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#issuecomment-493623478 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4220?src=pr&el=h1) Report > Merging [#4220](https://codecov.io/gh

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
snleee commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r285865028 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.j

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

2019-05-21 Thread GitBox
snleee commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r285865713 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.ja