Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag
metric from broker for queries hitting consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286277086
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java
##########
@@ -227,7 +227,6 @@ public void setMinConsumingFreshnessTimeMs(long
minConsumingFreshnessTimeMs) {
_minConsumingFreshnessTimeMs = minConsumingFreshnessTimeMs;
}
-
Review comment:
Can you add override annotations to the new introduced methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
