mcvsubbu commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r286092593
########## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ########## @@ -72,61 +63,66 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import static org.apache.pinot.common.utils.CommonConstants.Helix.*; +import static org.apache.pinot.common.utils.CommonConstants.Server.*; + /** - * Single server helix starter. Will start automatically with an untagged box. - * Will auto join current cluster as a participant. - * - * - * + * Starter for Helix-based Pinot server. Review comment: Suggest remove the words 'helix-based'. I suppose this is a left-over of file-based server that we had long ago, but we don't have anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
