snleee commented on a change in pull request #4222: Add startup/shutdown checks 
for HelixServerStarter
URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r285865028
 
 

 ##########
 File path: 
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java
 ##########
 @@ -163,15 +162,13 @@ protected void startServers(int numServers, int 
baseAdminApiPort, int baseNettyP
   protected void startServers(int numServers, Configuration configuration, int 
baseAdminApiPort, int baseNettyPort,
       String zkStr) {
     try {
+      overrideServerConf(configuration);
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to