Jackie-Jiang commented on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-494624812 > Just remembered one thing that might be good to keep in mind: the reason a shutdown resource check was added was to handle the case of ZK/Helix slowness where the broker's EV was lagging. At the time, @kishoreg had suggested that waiting at shutdown time is better as its a stronger guarantee than at startup (if Broker's view is lagging, it may continue to - esp if the instance-config update processing is lagging). > This change flips the argument somewhat. We'll still need a startup wait because of the latency issues noted. We might have to keep a closer on the following deployments as we now have the resource offline check turned off. Both shutdown/startup check needs to wait for controller to pickup the current state changes and put them into external view, thus shutdown check won't give stronger guarantee. I'll monitor the following deployments and see if we need to tune the default behavior (that's why I keep everything configurable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
