[GitHub] [doris] adonis0147 opened a new pull request, #15866: [regression-test](MTMV) Make the case test_create_mtmv more robust

2023-01-12 Thread GitBox
adonis0147 opened a new pull request, #15866: URL: https://github.com/apache/doris/pull/15866 # Proposed changes 1. Use the state of MTMV task as the loop condition. 2. Check the data in materialized view. ## Problem summary 1. The case used a retry strategy as the loo

[GitHub] [doris] github-actions[bot] commented on pull request #15864: [fix](sort spill) fix bug of failed to create spilled file

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15864: URL: https://github.com/apache/doris/pull/15864#issuecomment-1379943253 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15669: [feature](struct-type) adjust the vexpr for struct type

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15669: URL: https://github.com/apache/doris/pull/15669#discussion_r1067808419 ## be/src/vec/columns/column_struct.cpp: ## @@ -23,10 +23,10 @@ namespace doris::vectorized { namespace ErrorCodes { -extern const int ILLEGAL_COLUMN; -

[GitHub] [doris] englefly opened a new pull request, #15867: [fix](nereids)upgrade signature datatype bug

2023-01-12 Thread GitBox
englefly opened a new pull request, #15867: URL: https://github.com/apache/doris/pull/15867 # Proposed changes ComputeSignatureHelper.upgradeDateOrDateTimeToV2() we upgrate return date type, but forget to upgrade arguments datatype. The same problem in upgradeDecimalV2ToV3()

[GitHub] [doris] github-actions[bot] commented on pull request #15605: [improvement](projection) Improve projection performance

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15605: URL: https://github.com/apache/doris/pull/15605#issuecomment-1379954131 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15780: URL: https://github.com/apache/doris/pull/15780#issuecomment-1379955922 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15669: [feature](struct-type) adjust the vexpr for struct type

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15669: URL: https://github.com/apache/doris/pull/15669#discussion_r1067818064 ## be/src/vec/data_types/data_type_struct.cpp: ## @@ -23,14 +23,14 @@ namespace doris::vectorized { namespace ErrorCodes { -extern const int BAD_ARGUMEN

[GitHub] [doris] github-actions[bot] commented on pull request #15841: [Bug](join) fix bug null aware left anti join not correct result

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15841: URL: https://github.com/apache/doris/pull/15841#issuecomment-1379967101 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] spaces-X opened a new issue, #15868: [Feature] support QuantileState in vectorized engine

2023-01-12 Thread GitBox
spaces-X opened a new issue, #15868: URL: https://github.com/apache/doris/issues/15868 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description From #8234 pre-ag

[GitHub] [doris] github-actions[bot] commented on pull request #15605: [improvement](projection) Improve projection performance

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15605: URL: https://github.com/apache/doris/pull/15605#issuecomment-1379974411 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15623: URL: https://github.com/apache/doris/pull/15623#issuecomment-1379974541 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15623: URL: https://github.com/apache/doris/pull/15623#issuecomment-1379974498 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morrySnow merged pull request #15623: [fix](nereids) binding group by key on agg.output if output is slot

2023-01-12 Thread GitBox
morrySnow merged PR #15623: URL: https://github.com/apache/doris/pull/15623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on pull request #15605: [improvement](projection) Improve projection performance

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15605: URL: https://github.com/apache/doris/pull/15605#issuecomment-1379977953 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [fix](nereids) binding group by key on agg.output if output is slot (#15623)

2023-01-12 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d23646793c [fix](nereids) binding group by key

[GitHub] [doris] Henry2SS opened a new issue, #15869: [Enhancement] make max running txn per db more flexible

2023-01-12 Thread GitBox
Henry2SS opened a new issue, #15869: URL: https://github.com/apache/doris/issues/15869 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Now, we have a fe c

[GitHub] [doris] jacktengg commented on a diff in pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
jacktengg commented on code in PR #15859: URL: https://github.com/apache/doris/pull/15859#discussion_r1067837923 ## regression-test/suites/demo_p0/merge_sort.groovy: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[GitHub] [doris] Henry2SS commented on pull request #15830: [enhancement](load) change transaction limit from db level to user level

2023-01-12 Thread GitBox
Henry2SS commented on PR #15830: URL: https://github.com/apache/doris/pull/15830#issuecomment-1379980886 > You'd better explain why we change it, e.g. requests from users or resolving a problem. Thx for your advice. Done. Add a related issue. -- This is an automated message from

[GitHub] [doris] nothing-go-reade opened a new issue, #15870: update about file

2023-01-12 Thread GitBox
nothing-go-reade opened a new issue, #15870: URL: https://github.com/apache/doris/issues/15870 1 cp thirdparty/*.sh /var/local/thirdparty 2 cp thirdparty/patches /var/local/thirdparty -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [doris] hello-stephen commented on pull request #15858: [fix](Nereids): mergeGroup() consider GroupExpr in same/different Group

2023-01-12 Thread GitBox
hello-stephen commented on PR #15858: URL: https://github.com/apache/doris/pull/15858#issuecomment-1379982156 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.66 seconds load time: 495 seconds storage size: 17122884559 Bytes https://doris-co

[GitHub] [doris] jacktengg commented on a diff in pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
jacktengg commented on code in PR #15859: URL: https://github.com/apache/doris/pull/15859#discussion_r1067837923 ## regression-test/suites/demo_p0/merge_sort.groovy: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licens

[GitHub] [doris] morrySnow commented on a diff in pull request #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion

2023-01-12 Thread GitBox
morrySnow commented on code in PR #15833: URL: https://github.com/apache/doris/pull/15833#discussion_r1067844668 ## fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java: ## @@ -465,6 +468,8 @@ public Group mergeGroup(Group source, Group destination) { so

[GitHub] [doris] ByteYue commented on a diff in pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
ByteYue commented on code in PR #15859: URL: https://github.com/apache/doris/pull/15859#discussion_r1067846403 ## regression-test/suites/demo_p0/merge_sort.groovy: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

[GitHub] [doris] github-actions[bot] commented on pull request #15854: [fix](Nereids): throw exception when aliasedQuery has no alias

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15854: URL: https://github.com/apache/doris/pull/15854#issuecomment-1379990541 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15854: [fix](Nereids): throw exception when aliasedQuery has no alias

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15854: URL: https://github.com/apache/doris/pull/15854#issuecomment-1379990481 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris-spark-connector] caoliang-web opened a new pull request, #64: Return specific error information after optimizing the exception

2023-01-12 Thread GitBox
caoliang-web opened a new pull request, #64: URL: https://github.com/apache/doris-spark-connector/pull/64 ## Problem Summary: Return specific error information after optimizing the exception ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't k

[GitHub] [doris] platoneko commented on a diff in pull request #15633: [enhancement](compaction) Optimize calculating level size of input rowset in SizeBasedCumulativeCompactionPolicy

2023-01-12 Thread GitBox
platoneko commented on code in PR #15633: URL: https://github.com/apache/doris/pull/15633#discussion_r1067854490 ## be/src/olap/cumulative_compaction_policy.cpp: ## @@ -335,13 +325,12 @@ int SizeBasedCumulativeCompactionPolicy::pick_input_rowsets( return transient_size; }

[GitHub] [doris] github-actions[bot] commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15807: URL: https://github.com/apache/doris/pull/15807#issuecomment-1380003973 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] caiconghui commented on a diff in pull request #15830: [enhancement](load) change transaction limit from db level to user level

2023-01-12 Thread GitBox
caiconghui commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1067866074 ## docs/en/docs/admin-manual/config/fe-config.md: ## @@ -1005,7 +1005,7 @@ MasterOnly:true Maximum percentage of data that can be filtered (due to reasons such as

[GitHub] [doris] github-actions[bot] commented on pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15859: URL: https://github.com/apache/doris/pull/15859#issuecomment-1380017280 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 opened a new pull request, #15871: [refactor](rpc fn) decouple vectorized remote function from row-based one

2023-01-12 Thread GitBox
Gabriel39 opened a new pull request, #15871: URL: https://github.com/apache/doris/pull/15871 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [

[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15780: URL: https://github.com/apache/doris/pull/15780#issuecomment-1380021068 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15871: [refactor](rpc fn) decouple vectorized remote function from row-based one

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15871: URL: https://github.com/apache/doris/pull/15871#issuecomment-1380021887 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yuanyuan8983 opened a new pull request, #15872: [style](FE)change PaloFe to DorisFe

2023-01-12 Thread GitBox
yuanyuan8983 opened a new pull request, #15872: URL: https://github.com/apache/doris/pull/15872 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [

[GitHub] [doris] jacktengg commented on pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
jacktengg commented on PR #15859: URL: https://github.com/apache/doris/pull/15859#issuecomment-1380025087 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] github-actions[bot] commented on pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15859: URL: https://github.com/apache/doris/pull/15859#issuecomment-1380026632 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] qidaye commented on a diff in pull request #15821: [Feature-WIP](inverted index) inverted index writer's implementation

2023-01-12 Thread GitBox
qidaye commented on code in PR #15821: URL: https://github.com/apache/doris/pull/15821#discussion_r1067885554 ## be/src/olap/olap_common.h: ## @@ -198,6 +198,22 @@ enum ReaderType { READER_CHECKSUM = 4, }; +constexpr bool field_is_slice_type(const FieldType& field_type)

[GitHub] [doris] qidaye commented on a diff in pull request #15821: [Feature-WIP](inverted index) inverted index writer's implementation

2023-01-12 Thread GitBox
qidaye commented on code in PR #15821: URL: https://github.com/apache/doris/pull/15821#discussion_r1067885554 ## be/src/olap/olap_common.h: ## @@ -198,6 +198,22 @@ enum ReaderType { READER_CHECKSUM = 4, }; +constexpr bool field_is_slice_type(const FieldType& field_type)

[GitHub] [doris] dataroaring commented on a diff in pull request #15832: [Feature](remote) Cooldown cold data to object storage only one replica

2023-01-12 Thread GitBox
dataroaring commented on code in PR #15832: URL: https://github.com/apache/doris/pull/15832#discussion_r1067666463 ## be/src/common/config.h: ## @@ -815,6 +815,7 @@ CONF_Int32(concurrency_per_dir, "2"); CONF_mInt64(cooldown_lag_time_sec, "10800"); // 3h CONF_mInt64(max_s

[GitHub] [doris] github-actions[bot] commented on pull request #15817: [fix](planner) move join reorder to the single node planner

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15817: URL: https://github.com/apache/doris/pull/15817#issuecomment-1380064685 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15817: [fix](planner) move join reorder to the single node planner

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15817: URL: https://github.com/apache/doris/pull/15817#issuecomment-1380064803 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Henry2SS commented on a diff in pull request #15830: [enhancement](load) change transaction limit from db level to user level

2023-01-12 Thread GitBox
Henry2SS commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1067911159 ## docs/en/docs/admin-manual/config/fe-config.md: ## @@ -1005,7 +1005,7 @@ MasterOnly:true Maximum percentage of data that can be filtered (due to reasons such as d

[GitHub] [doris] platoneko commented on a diff in pull request #15832: [Feature](remote) Cooldown cold data to object storage only one replica

2023-01-12 Thread GitBox
platoneko commented on code in PR #15832: URL: https://github.com/apache/doris/pull/15832#discussion_r1067913105 ## fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java: ## @@ -1486,11 +1486,11 @@ private void createJob(long dbId, OlapTable olapTable, Map

[GitHub] [doris] hello-stephen commented on pull request #15859: [Bug](sort)fix merge sorter might div zero when block bytes less than block rows

2023-01-12 Thread GitBox
hello-stephen commented on PR #15859: URL: https://github.com/apache/doris/pull/15859#issuecomment-1380077818 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.29 seconds load time: 560 seconds storage size: 17123097128 Bytes https://doris-co

[GitHub] [doris] github-actions[bot] commented on pull request #15766: [pick](compaction) pick vertical&ordered_data compaction to 1.2

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15766: URL: https://github.com/apache/doris/pull/15766#issuecomment-1380078939 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15766: [pick](compaction) pick vertical&ordered_data compaction to 1.2

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15766: URL: https://github.com/apache/doris/pull/15766#issuecomment-1380079006 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15836: [fix](multi catalog)Support iceberg schema evolution.

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15836: URL: https://github.com/apache/doris/pull/15836#issuecomment-1380079776 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #15860: [Bug](datev2) Fix bugs for datev2

2023-01-12 Thread GitBox
hello-stephen commented on PR #15860: URL: https://github.com/apache/doris/pull/15860#issuecomment-1380089376 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.79 seconds load time: 494 seconds storage size: 17122600336 Bytes https://doris-co

[GitHub] [doris] Yukang-Lian commented on pull request #15872: [style](FE)change PaloFe to DorisFe

2023-01-12 Thread GitBox
Yukang-Lian commented on PR #15872: URL: https://github.com/apache/doris/pull/15872#issuecomment-1380091314 https://github.com/apache/doris/blob/d23646793c71ea44e8e9f6b5f28acd9b5b51e237/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java#L124 maybe this line also needs to be modifie

[GitHub] [doris] platoneko opened a new pull request, #15873: [feature](cooldown) Decouple storage policy and resource (BE)

2023-01-12 Thread GitBox
platoneko opened a new pull request, #15873: URL: https://github.com/apache/doris/pull/15873 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] luozenglin opened a new pull request, #15874: [fix](brokerload) fix be core dump casued by broker load

2023-01-12 Thread GitBox
luozenglin opened a new pull request, #15874: URL: https://github.com/apache/doris/pull/15874 # Proposed changes Issue Number: close 15846 ## Problem summary The BrokerFileReader is refactored in #15622, but the _client is not initialized ## Checklist(Required)

[GitHub] [doris] github-actions[bot] commented on pull request #15829: [fix](olap) dictionary cannot be sorted after inserting some null values

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15829: URL: https://github.com/apache/doris/pull/15829#issuecomment-1380098991 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15829: [fix](olap) dictionary cannot be sorted after inserting some null values

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15829: URL: https://github.com/apache/doris/pull/15829#issuecomment-1380099075 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15874: URL: https://github.com/apache/doris/pull/15874#issuecomment-1380099710 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15873: [feature](cooldown) Decouple storage policy and resource (BE)

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15873: URL: https://github.com/apache/doris/pull/15873#discussion_r1067942363 ## be/src/io/fs/s3_file_system.h: ## @@ -70,13 +71,13 @@ class S3FileSystem final : public RemoteFileSystem { }; // Guarded by external lock. -

[GitHub] [doris] dutyu opened a new pull request, #15875: [Feature](profile) set sql and defaultDb fields in show-load-profile.

2023-01-12 Thread GitBox
dutyu opened a new pull request, #15875: URL: https://github.com/apache/doris/pull/15875 # Proposed changes When execute `show load profile '/'`, the value of `SQL` and `DefaultDb` columns are all 'N/A', but we can fill these fields,the result of this pr is as follows: Execute

[GitHub] [doris] zbtzbtzbt opened a new pull request, #15876: [fix] remove echo database passwd

2023-01-12 Thread GitBox
zbtzbtzbt opened a new pull request, #15876: URL: https://github.com/apache/doris/pull/15876 # Proposed changes echo password is dangerous, we should delete it. ![echo_passwd](https://user-images.githubusercontent.com/35688959/212043801-ebee6028-f6b9-4ee1-b46c-b082e416fdae.png)

[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix] remove echo database passwd

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15876: URL: https://github.com/apache/doris/pull/15876#issuecomment-1380132618 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3901438284";) output. shellcheck err

[GitHub] [doris] hello-stephen commented on pull request #15760: [Chore](build) enable -Wextra and remove some -Wno

2023-01-12 Thread GitBox
hello-stephen commented on PR #15760: URL: https://github.com/apache/doris/pull/15760#issuecomment-1380145442 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.64 seconds load time: 496 seconds storage size: 17123165845 Bytes https://doris-co

[GitHub] [doris] dataroaring commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load

2023-01-12 Thread GitBox
dataroaring commented on PR #15874: URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151176 We should add regression test for broker load. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15874: URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151781 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15874: URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151721 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix](terminal) remove echo database passwd

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15876: URL: https://github.com/apache/doris/pull/15876#issuecomment-1380156336 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3901582592";) output. shellcheck err

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15605: [improvement](projection) Improve projection performance

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15605: URL: https://github.com/apache/doris/pull/15605#discussion_r1067986937 ## be/src/vec/exec/join/vjoin_node_base.cpp: ## @@ -104,51 +104,92 @@ void VJoinNodeBase::_construct_mutable_join_block() { _join_block.col

[GitHub] [doris] xinyiZzz commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM

2023-01-12 Thread GitBox
xinyiZzz commented on PR #15217: URL: https://github.com/apache/doris/pull/15217#issuecomment-1380174035 > This pr sets the repeat count to the smaller value of count and `repeat_max_num`, which may cause the result to be inconsistent with the user's expectations and there is no error promp

[GitHub] [doris] zbtzbtzbt commented on pull request #15876: [fix](terminal) remove echo database passwd

2023-01-12 Thread GitBox
zbtzbtzbt commented on PR #15876: URL: https://github.com/apache/doris/pull/15876#issuecomment-1380183534 use shfmt to format. e.g. `shfmt -w tools/ssb-tools/bin/load-ssb-data.sh` -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15780: URL: https://github.com/apache/doris/pull/15780#issuecomment-1380187343 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15832: [Feature](remote) Cooldown cold data to object storage only one replica

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15832: URL: https://github.com/apache/doris/pull/15832#discussion_r1068015594 ## be/src/io/fs/file_reader_options.h: ## @@ -38,23 +38,25 @@ public: // path: the path of file which will be cached // return value: the cache p

[GitHub] [doris] hello-stephen commented on pull request #15862: [feature](multi-catalog) support oracle jdbc catalog

2023-01-12 Thread GitBox
hello-stephen commented on PR #15862: URL: https://github.com/apache/doris/pull/15862#issuecomment-1380197082 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.27 seconds load time: 488 seconds storage size: 17123040156 Bytes https://doris-co

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15832: [Feature](remote) Cooldown cold data to object storage only one replica

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15832: URL: https://github.com/apache/doris/pull/15832#discussion_r1068039602 ## be/src/olap/tablet.cpp: ## @@ -1717,27 +1735,135 @@ Status Tablet::cooldown() { new_rowset_meta->set_resource_id(dest_fs->resource_id()); new_r

[GitHub] [doris] github-actions[bot] commented on pull request #15718: [fix](schema scanner)change schema_scanner::get_next_row to get_next_block

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15718: URL: https://github.com/apache/doris/pull/15718#issuecomment-1380226343 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15843: [vectorzied](jdbc) fix jdbc executor for get result by batch and memo…

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15843: URL: https://github.com/apache/doris/pull/15843#issuecomment-1380233020 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xy720 commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

2023-01-12 Thread GitBox
xy720 commented on PR #15748: URL: https://github.com/apache/doris/pull/15748#issuecomment-1380233483 Update docs and add regression test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15832: [Feature](remote) Cooldown cold data to object storage only one replica

2023-01-12 Thread GitBox
github-actions[bot] commented on code in PR #15832: URL: https://github.com/apache/doris/pull/15832#discussion_r1068050963 ## be/test/io/cache/remote_file_cache_test.cpp: ## @@ -141,7 +141,11 @@ class RemoteFileCacheTest : public ::testing::Test { EXPECT_NE("", writer.m

[GitHub] [doris] hello-stephen commented on pull request #15864: [fix](sort spill) fix bug of failed to create spilled file

2023-01-12 Thread GitBox
hello-stephen commented on PR #15864: URL: https://github.com/apache/doris/pull/15864#issuecomment-1380242924 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.88 seconds load time: 492 seconds storage size: 17121768362 Bytes https://doris-co

[GitHub] [doris] tempestLXC commented on issue #15694: [Bug] register txn replica failed

2023-01-12 Thread GitBox
tempestLXC commented on issue #15694: URL: https://github.com/apache/doris/issues/15694#issuecomment-1380244050 我也遇到同样的问题了 但是是在 binlog load 时出现的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [doris] github-actions[bot] commented on pull request #15781: [typo](docs)Update ARRAY.md

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15781: URL: https://github.com/apache/doris/pull/15781#issuecomment-1380258364 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #15821: [Feature-WIP](inverted index) inverted index writer's implementation

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15821: URL: https://github.com/apache/doris/pull/15821#issuecomment-1380260666 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] hello-stephen commented on pull request #15867: [fix](nereids)upgrade signature datatype bug

2023-01-12 Thread GitBox
hello-stephen commented on PR #15867: URL: https://github.com/apache/doris/pull/15867#issuecomment-1380264553 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.55 seconds load time: 510 seconds storage size: 17122419051 Bytes https://doris-co

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068074792 ## be/src/vec/exec/scan/vscan_node.cpp: ## @@ -966,6 +966,24 @@ Status VScanNode::_normalize_compound_predicate( },

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068073938 ## be/src/vec/exec/scan/vscan_node.h: ## @@ -334,6 +334,11 @@ class VScanNode : public ExecNode { SlotDescriptor* sl

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068074792 ## be/src/vec/exec/scan/vscan_node.cpp: ## @@ -966,6 +966,24 @@ Status VScanNode::_normalize_compound_predicate( },

[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15794: URL: https://github.com/apache/doris/pull/15794#issuecomment-1380291177 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #15830: [enhancement](load) change transaction limit from db level to user level

2023-01-12 Thread GitBox
hello-stephen commented on PR #15830: URL: https://github.com/apache/doris/pull/15830#issuecomment-1380299854 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.88 seconds load time: 489 seconds storage size: 17122161492 Bytes https://doris-co

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068092190 ## be/src/olap/rowset/segment_v2/inverted_index_reader.cpp: ## @@ -17,30 +17,288 @@ #include "olap/rowset/segment_v2/inverted_index_reader.h" -#include "common/sta

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068093312 ## be/src/olap/rowset/segment_v2/inverted_index_reader.cpp: ## @@ -17,30 +17,288 @@ #include "olap/rowset/segment_v2/inverted_index_reader.h" -#include "common/sta

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068095484 ## be/src/olap/rowset/segment_v2/inverted_index_reader.cpp: ## @@ -17,30 +17,288 @@ #include "olap/rowset/segment_v2/inverted_index_reader.h" -#include "common/sta

[GitHub] [doris] github-actions[bot] commented on pull request #14531: [improvement](meta) make database,table,column names to support unicode (replace PR #13467 with this)

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #14531: URL: https://github.com/apache/doris/pull/14531#issuecomment-1380315382 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

2023-01-12 Thread GitBox
Tanya-W commented on code in PR #15823: URL: https://github.com/apache/doris/pull/15823#discussion_r1068100535 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -580,6 +581,10 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() { }

[GitHub] [doris] tempestLXC opened a new issue, #15877: [Bug] 通过canal订阅binlog , 同步数据不生效

2023-01-12 Thread GitBox
tempestLXC opened a new issue, #15877: URL: https://github.com/apache/doris/issues/15877 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.0 ### What

[GitHub] [doris] yixiutt commented on a diff in pull request #15749: [improvement](reader) use union merge when rowset are noneoverlapping

2023-01-12 Thread GitBox
yixiutt commented on code in PR #15749: URL: https://github.com/apache/doris/pull/15749#discussion_r1068116639 ## be/src/vec/olap/vcollect_iterator.cpp: ## @@ -129,6 +132,19 @@ Status VCollectIterator::build_heap(std::vector& rs_reade new Level1Iterator(_ch

[GitHub] [doris] github-actions[bot] commented on pull request #15749: [improvement](reader) use union merge when rowset are noneoverlapping

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15749: URL: https://github.com/apache/doris/pull/15749#issuecomment-1380358681 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #15801: [Enhancement](export) cancel all running coordinators when execute ca…

2023-01-12 Thread GitBox
hello-stephen commented on PR #15801: URL: https://github.com/apache/doris/pull/15801#issuecomment-1380371548 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.68 seconds load time: 490 seconds storage size: 17123207626 Bytes https://doris-co

[GitHub] [doris] Kikyou1997 opened a new pull request, #15878: [fix](planner) Keep type of null literal expr when register conjuncts

2023-01-12 Thread GitBox
Kikyou1997 opened a new pull request, #15878: URL: https://github.com/apache/doris/pull/15878 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ]

[GitHub] [doris] hello-stephen commented on pull request #15871: [refactor](rpc fn) decouple vectorized remote function from row-based one

2023-01-12 Thread GitBox
hello-stephen commented on PR #15871: URL: https://github.com/apache/doris/pull/15871#issuecomment-1380386649 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 36.12 seconds load time: 493 seconds storage size: 17122714651 Bytes https://doris-co

[GitHub] [doris] cambyzju opened a new pull request, #15879: [fix](struct-type) struct create failed fix

2023-01-12 Thread GitBox
cambyzju opened a new pull request, #15879: URL: https://github.com/apache/doris/pull/15879 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] adonis0147 commented on a diff in pull request #15876: [fix](terminal) remove echo database passwd

2023-01-12 Thread GitBox
adonis0147 commented on code in PR #15876: URL: https://github.com/apache/doris/pull/15876#discussion_r1068146932 ## tools/ssb-tools/bin/gen-ssb-data.sh: ## @@ -126,7 +126,7 @@ date cd - # move data to $SSB_DATA_DIR -mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/" +mv "${SSB

[GitHub] [doris] github-actions[bot] commented on pull request #15879: [fix](struct-type) struct create failed fix

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15879: URL: https://github.com/apache/doris/pull/15879#issuecomment-1380393881 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15879: [fix](struct-type) struct create failed fix

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #15879: URL: https://github.com/apache/doris/pull/15879#issuecomment-1380394160 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman merged pull request #15807: [Update](deps) add clucene deps for doris inverted index

2023-01-12 Thread GitBox
morningman merged PR #15807: URL: https://github.com/apache/doris/pull/15807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

  1   2   3   >