github-actions[bot] commented on code in PR #15832:
URL: https://github.com/apache/doris/pull/15832#discussion_r1068050963


##########
be/test/io/cache/remote_file_cache_test.cpp:
##########
@@ -141,7 +141,11 @@ class RemoteFileCacheTest : public ::testing::Test {
         EXPECT_NE("", writer.min_encoded_key().to_string());
         EXPECT_NE("", writer.max_encoded_key().to_string());
 
-        st = segment_v2::Segment::open(fs, path, 0, {}, query_schema, res);
+        io::SegmentCachePathPolicy cache_policy;
+        cache_policy.set_cache_path(segment_cache_path(0));

Review Comment:
   warning: use of undeclared identifier 'segment_cache_path' 
[clang-diagnostic-error]
   ```cpp
           cache_policy.set_cache_path(segment_cache_path(0));
                                       ^
   ```
   



##########
be/test/tools/benchmark_tool.cpp:
##########
@@ -363,7 +363,11 @@ class SegmentBenchmark : public BaseBenchmark {
         writer.finalize(&file_size, &index_size);
         file_writer->close();
 
-        Segment::open(fs, path, "", seg_id, {}, &_tablet_schema, res);
+        io::SegmentCachePathPolicy cache_policy;
+        cache_policy.set_cache_path(segment_cache_path(seg_id));

Review Comment:
   warning: use of undeclared identifier 'segment_cache_path' 
[clang-diagnostic-error]
   ```cpp
           cache_policy.set_cache_path(segment_cache_path(seg_id));
                                       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to