github-actions[bot] commented on code in PR #15669:
URL: https://github.com/apache/doris/pull/15669#discussion_r1067808419
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -23,10 +23,10 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int ILLEGAL_COLUMN;
-extern const int NOT_IMPLEMENTED;
-extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
-extern const int LOGICAL_ERROR;
+const int ILLEGAL_COLUMN = 44;
Review Comment:
warning: unused variable 'ILLEGAL_COLUMN'
[clang-diagnostic-unused-const-variable]
```cpp
const int ILLEGAL_COLUMN = 44;
^
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -23,10 +23,10 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int ILLEGAL_COLUMN;
-extern const int NOT_IMPLEMENTED;
-extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
-extern const int LOGICAL_ERROR;
+const int ILLEGAL_COLUMN = 44;
+const int NOT_IMPLEMENTED = 48;
+const int LOGICAL_ERROR = 49;
+const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE = 120;
Review Comment:
warning: unused variable 'CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE'
[clang-diagnostic-unused-const-variable]
```cpp
const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE = 120;
^
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -23,10 +23,10 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int ILLEGAL_COLUMN;
-extern const int NOT_IMPLEMENTED;
-extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
-extern const int LOGICAL_ERROR;
+const int ILLEGAL_COLUMN = 44;
+const int NOT_IMPLEMENTED = 48;
+const int LOGICAL_ERROR = 49;
Review Comment:
warning: unused variable 'LOGICAL_ERROR'
[clang-diagnostic-unused-const-variable]
```cpp
const int LOGICAL_ERROR = 49;
^
```
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -23,10 +23,10 @@
namespace doris::vectorized {
namespace ErrorCodes {
-extern const int ILLEGAL_COLUMN;
-extern const int NOT_IMPLEMENTED;
-extern const int CANNOT_INSERT_VALUE_OF_DIFFERENT_SIZE_INTO_TUPLE;
-extern const int LOGICAL_ERROR;
+const int ILLEGAL_COLUMN = 44;
+const int NOT_IMPLEMENTED = 48;
Review Comment:
warning: unused variable 'NOT_IMPLEMENTED'
[clang-diagnostic-unused-const-variable]
```cpp
const int NOT_IMPLEMENTED = 48;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
