[GitHub] [doris] Tanya-W commented on a diff in pull request #15823: [Feature-WIP](inverted index) inverted index reader's implementation, and add mysql_fulltext regression case to test fulltext query

[GitBox]

Tanya-W commented on code in PR #15823:
URL: https://github.com/apache/doris/pull/15823#discussion_r1068074792


##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -966,6 +966,24 @@ Status VScanNode::_normalize_compound_predicate(
                             },
                             active_range);
 
+                    _compound_value_ranges.emplace_back(active_range);
+                }
+            } else if (TExprNodeType::MATCH_PRED == child_expr->node_type()) {
+                SlotDescriptor* slot = nullptr;
+                ColumnValueRangeType* range_on_slot = nullptr;
+                if (_is_predicate_acting_on_slot(child_expr, 
in_predicate_checker, &slot,

Review Comment:
   match_checker in function `_normalize_match_predicate`



##########
be/src/olap/reader.cpp:
##########
@@ -452,6 +452,8 @@ void TabletReader::_init_conditions_param(const 
ReaderParams& read_params) {
         ColumnPredicate* predicate =
                 parse_to_predicate(_tablet_schema, tmp_cond, 
_predicate_mem_pool.get());
         if (predicate != nullptr) {
+            auto predicate_params = predicate->predicate_params();
+            predicate_params->value = condition.condition_values[0];

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org