qidaye commented on code in PR #15821:
URL: https://github.com/apache/doris/pull/15821#discussion_r1067885554
##########
be/src/olap/olap_common.h:
##########
@@ -198,6 +198,22 @@ enum ReaderType {
READER_CHECKSUM = 4,
};
+constexpr bool field_is_slice_type(const FieldType& field_type) {
+ return field_type == OLAP_FIELD_TYPE_VARCHAR || field_type ==
OLAP_FIELD_TYPE_CHAR ||
+ field_type == OLAP_FIELD_TYPE_STRING;
+}
+
+constexpr bool field_is_numeric_type(const FieldType& field_type) {
+ return field_type == OLAP_FIELD_TYPE_INT || field_type ==
OLAP_FIELD_TYPE_UNSIGNED_INT ||
+ field_type == OLAP_FIELD_TYPE_BIGINT || field_type ==
OLAP_FIELD_TYPE_SMALLINT ||
+ field_type == OLAP_FIELD_TYPE_UNSIGNED_TINYINT ||
+ field_type == OLAP_FIELD_TYPE_UNSIGNED_SMALLINT ||
+ field_type == OLAP_FIELD_TYPE_TINYINT || field_type ==
OLAP_FIELD_TYPE_DOUBLE ||
+ field_type == OLAP_FIELD_TYPE_FLOAT || field_type ==
OLAP_FIELD_TYPE_DATE ||
+ field_type == OLAP_FIELD_TYPE_DATETIME || field_type ==
OLAP_FIELD_TYPE_LARGEINT ||
Review Comment:
Remeber the new data types, like DECIMALV3 and DATETIMEV2 and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
