doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1964107862
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23950)
Line Coverage: 27.48% (69379/252451)
Region Coverage: 26.64% (35978/135033)
Branch Coverage: 23.4
Lchangliang commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963992914
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502497752
##
be/src/cloud/cloud_rowset_writer.cpp:
##
@@ -34,6 +35,7 @@ Status CloudRowsetWriter::init(const RowsetWriterContext&
rowset_writer_context)
// TODO(plat1
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502493129
##
be/src/olap/schema_change.cpp:
##
@@ -652,97 +658,111 @@ Status
VSchemaChangeWithSorting::_external_sorting(vector& src_
return Status::OK();
}
-Status Sc
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502482544
##
be/src/olap/schema_change.cpp:
##
@@ -1358,57 +1355,70 @@ Status
SchemaChangeHandler::_validate_alter_result(TabletSharedPtr new_tablet,
// incremental rowsets.
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502482544
##
be/src/olap/schema_change.cpp:
##
@@ -1358,57 +1355,70 @@ Status
SchemaChangeHandler::_validate_alter_result(TabletSharedPtr new_tablet,
// incremental rowsets.
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502480498
##
be/src/olap/schema_change.cpp:
##
@@ -1358,57 +1355,70 @@ Status
SchemaChangeHandler::_validate_alter_result(TabletSharedPtr new_tablet,
// incremental rowsets.
Lchangliang commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963929476
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963752485
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0a5beb4bfbed94845f74aa74bf451b7573f6eb85 with
default session variables
Stream
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963746375
ClickBench: Total hot run time: 31.92 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963735114
TPC-DS: Total hot run time: 181831 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963719635
TeamCity be ut coverage result:
Function Coverage: 35.70% (8547/23940)
Line Coverage: 27.49% (69353/252295)
Region Coverage: 26.64% (35968/134992)
Branch Coverage: 23.4
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963711774
TPC-H: Total hot run time: 38581 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
Lchangliang commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963626177
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963237126
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit f1b93e9f82eb44a5a13bcee8e2897107692e704e with
default session variables
Stream
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963234780
ClickBench: Total hot run time: 31.02 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963230963
TPC-DS: Total hot run time: 188388 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963230508
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23954)
Line Coverage: 27.49% (69362/252355)
Region Coverage: 26.65% (35970/134994)
Branch Coverage: 23.4
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963223114
TPC-H: Total hot run time: 41483 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1501981363
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,361 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
Lchangliang commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963207992
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963202184
TPC-H: Total hot run time: 41239 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963200139
TeamCity be ut coverage result:
Function Coverage: 35.69% (8548/23954)
Line Coverage: 27.49% (69364/252354)
Region Coverage: 26.65% (35972/134994)
Branch Coverage: 23.4
dataroaring commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1963174269
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962796064
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4c39df9bc6dab64b7fb1910d6f85b4de075672c3 with
default session variables
Stream
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962795610
ClickBench: Total hot run time: 30.72 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962794887
TPC-DS: Total hot run time: 188798 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962793555
TeamCity be ut coverage result:
Function Coverage: 35.68% (8547/23954)
Line Coverage: 27.48% (69359/252355)
Region Coverage: 26.65% (35979/134995)
Branch Coverage: 23.4
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962793223
TPC-H: Total hot run time: 41455 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
dataroaring commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962785082
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gavinchou commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380270
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
gavinchou commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380148
run buidlall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1500456777
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
github-actions[bot] commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1495359187
##
be/src/olap/schema_change.cpp:
##
@@ -934,80 +944,81 @@
}
{
std::lock_guard wrlock(_mutex);
-_tablet_ids_in_co
doris-robot commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1953625576
TeamCity be ut coverage result:
Function Coverage: 35.75% (8557/23939)
Line Coverage: 27.68% (69406/250703)
Region Coverage: 26.81% (36019/134345)
Branch Coverage: 23.6
Lchangliang commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1495348358
##
be/src/olap/schema_change.cpp:
##
@@ -647,12 +661,29 @@ Status
VSchemaChangeWithSorting::_external_sorting(vector& src_
Merger::Statistics stats;
RETU
Lchangliang commented on PR #31055:
URL: https://github.com/apache/doris/pull/31055#issuecomment-1953569633
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1495220044
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,359 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494553536
##
be/src/olap/schema_change.cpp:
##
@@ -678,71 +709,74 @@ Status SchemaChangeHandler::process_alter_tablet_v2(const
TAlterTabletReqV2& req
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494552903
##
be/src/olap/schema_change.cpp:
##
@@ -678,71 +709,74 @@ Status SchemaChangeHandler::process_alter_tablet_v2(const
TAlterTabletReqV2& req
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494551700
##
be/src/olap/schema_change.cpp:
##
@@ -647,12 +661,29 @@ Status
VSchemaChangeWithSorting::_external_sorting(vector& src_
Merger::Statistics stats;
RETU
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494546602
##
be/src/olap/schema_change.cpp:
##
@@ -664,7 +695,7 @@ Status SchemaChangeHandler::process_alter_tablet_v2(const
TAlterTabletReqV2& req
<< ", alte
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494547587
##
be/src/olap/schema_change.cpp:
##
@@ -664,7 +695,7 @@ Status SchemaChangeHandler::process_alter_tablet_v2(const
TAlterTabletReqV2& req
<< ", alte
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494521529
##
be/src/cloud/cloud_tablet.h:
##
@@ -35,7 +35,7 @@ class CloudTablet final : public BaseTablet {
b
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494514680
##
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:
##
@@ -962,6 +991,14 @@ private void changeTableState(long dbId, long tableId,
OlapTable
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494512091
##
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##
@@ -629,6 +646,9 @@ protected boolean cancelImpl(String errMsg) {
this.errMsg = err
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494510761
##
fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java:
##
@@ -574,7 +591,7 @@ protected void runRunningJob() throws AlterCancelException {
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494433419
##
fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java:
##
@@ -0,0 +1,209 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494433034
##
fe/fe-core/src/main/java/org/apache/doris/alter/CloudRollupJobV2.java:
##
@@ -0,0 +1,209 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
github-actions[bot] commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494264567
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,334 @@
+#include "cloud/cloud_schema_change_job.h"
+
+#include
+#include
+
+#include "cloud/clo
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494003957
##
be/src/olap/schema_change.cpp:
##
@@ -624,18 +604,16 @@ Result>
VSchemaChangeWithSorting:
} else {
rowset_writer = std::move(result).value();
}
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1493996872
##
be/src/olap/schema_change.cpp:
##
@@ -85,7 +90,7 @@ constexpr int ALTER_TABLE_BATCH_SIZE = 4064;
class MultiBlockMerger {
public:
-MultiBlockMerger(TabletS
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1493994661
##
be/src/cloud/cloud_schema_change_job.h:
##
@@ -0,0 +1,35 @@
+#pragma once
+
+#include
+#include "cloud/cloud_storage_engine.h"
+#include "olap/rowset/rowset.h"
+#
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1493994262
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,335 @@
+#include "cloud/cloud_schema_change_job.h"
+
+#include
+#include
+
+#include "cloud/cloud_tablet_
platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1493994014
##
be/src/cloud/cloud_schema_change_job.cpp:
##
@@ -0,0 +1,335 @@
+#include "cloud/cloud_schema_change_job.h"
+
+#include
+#include
+
+#include "cloud/cloud_tablet_
55 matches
Mail list logo
