platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1502493129


##########
be/src/olap/schema_change.cpp:
##########
@@ -652,97 +658,111 @@ Status 
VSchemaChangeWithSorting::_external_sorting(vector<RowsetSharedPtr>& src_
     return Status::OK();
 }
 
-Status SchemaChangeHandler::process_alter_tablet_v2(const TAlterTabletReqV2& 
request) {
+Status VLocalSchemaChangeWithSorting::_inner_process(RowsetReaderSharedPtr 
rowset_reader,
+                                                     RowsetWriter* 
rowset_writer,
+                                                     BaseTabletSPtr new_tablet,
+                                                     TabletSchemaSPtr 
base_tablet_schema,
+                                                     TabletSchemaSPtr 
new_tablet_schema) {
+    Defer defer {[&]() {
+        // remove the intermediate rowsets generated by internal sorting
+        for (auto& row_set : _src_rowsets) {
+            _local_storage_engine.add_unused_rowset(row_set);
+        }
+    }};
+    _pending_rs_guards.clear();
+    LOG_INFO("lightman VLocalSchemaChangeWithSorting::_inner_process");

Review Comment:
   debug log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to