dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494551700
##########
be/src/olap/schema_change.cpp:
##########
@@ -647,12 +661,29 @@ Status
VSchemaChangeWithSorting::_external_sorting(vector<RowsetSharedPtr>& src_
Merger::Statistics stats;
RETURN_IF_ERROR(Merger::vmerge_rowsets(new_tablet,
ReaderType::READER_ALTER_TABLE,
*new_tablet_schema, rs_readers,
rowset_writer, &stats));
+ LOG_INFO("lightman _external_sorting").tag("merged_rows",
stats.merged_rows)
+ .tag("src_rowsets len", src_rowsets.size());
_add_merged_rows(stats.merged_rows);
_add_filtered_rows(stats.filtered_rows);
return Status::OK();
}
-Status SchemaChangeHandler::process_alter_tablet_v2(const TAlterTabletReqV2&
request) {
+Status VLocalSchemaChangeWithSorting::_inner_process(RowsetReaderSharedPtr
rowset_reader, RowsetWriter* rowset_writer,
+ BaseTabletSPtr new_tablet, TabletSchemaSPtr
base_tablet_schema,
+ TabletSchemaSPtr new_tablet_schema) {
+ Defer defer {[&]() {
+ // remove the intermediate rowsets generated by internal sorting
Review Comment:
1. The request is used in construct of SchemaChangeJob, and checked here?
2. _base_tablet is set in construct of schemachangejob, and checked here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
