platoneko commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1493994661
##########
be/src/cloud/cloud_schema_change_job.h:
##########
@@ -0,0 +1,35 @@
+#pragma once
+
+#include <memory>
+#include "cloud/cloud_storage_engine.h"
+#include "olap/rowset/rowset.h"
+#include "olap/schema_change.h"
+#include "cloud/cloud_tablet.h"
+#include "olap/tablet_fwd.h"
+
+namespace doris::cloud {
+
+class CloudSchemaChangeJob {
+public:
+ CloudSchemaChangeJob(CloudStorageEngine& cloud_storage_engine, std::string
job_id, int64_t expiration);
+ ~CloudSchemaChangeJob();
+
+ // This method is idempotent for a same request.
+ Status process_alter_tablet(const TAlterTabletReqV2& request);
+
+private:
+ Status _convert_historical_rowsets(const SchemaChangeParams& sc_params);
+
+private:
+ CloudStorageEngine& _cloud_storage_engine;
+ std::shared_ptr<CloudTablet> _base_tablet;
+ std::shared_ptr<CloudTablet> _new_tablet;
+ TabletSchemaSPtr _base_tablet_schema;
+ TabletSchemaSPtr _new_tablet_schema;
+ std::string _job_id;
+ std::vector<RowsetSharedPtr> _output_rowsets;
+ int64_t _output_cumulative_point;
Review Comment:
需要一个初始化值，看着构造函数也没初始化这个
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
