dataroaring commented on code in PR #31055:
URL: https://github.com/apache/doris/pull/31055#discussion_r1494553536
##########
be/src/olap/schema_change.cpp:
##########
@@ -678,71 +709,74 @@ Status SchemaChangeHandler::process_alter_tablet_v2(const
TAlterTabletReqV2& req
request.base_tablet_id);
}
- Status res = _do_process_alter_tablet_v2(request);
+ Status res = _do_process_alter_tablet(request);
LOG(INFO) << "finished alter tablet process, res=" << res;
return res;
}
-std::shared_mutex SchemaChangeHandler::_mutex;
-std::unordered_set<int64_t> SchemaChangeHandler::_tablet_ids_in_converting;
+SchemaChangeJob::SchemaChangeJob(StorageEngine& local_storage_engine, const
TAlterTabletReqV2& request)
+ : _local_storage_engine(local_storage_engine) {
+ _base_tablet =
_local_storage_engine.tablet_manager()->get_tablet(request.base_tablet_id);
+ _new_tablet =
_local_storage_engine.tablet_manager()->get_tablet(request.new_tablet_id);
+ _base_tablet_schema = std::make_shared<TabletSchema>();
+ if (_base_tablet && _new_tablet) {
Review Comment:
signal::tablet_id is typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
