[incubator-doris] branch master updated: [Bug] Fix bug that should not use "!=" to judge the equivalence of Type (#3786)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ea5b3b2 [Bug] Fix bug that should not u

[GitHub] [incubator-doris] imay closed issue #3785: [Bug][Load] Now() function is only support for DATE/DATETIME column

2020-06-05 Thread GitBox
imay closed issue #3785: URL: https://github.com/apache/incubator-doris/issues/3785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] imay merged pull request #3786: [Bug] Fix bug that should not use "!=" to judge the equivalence of Type

2020-06-05 Thread GitBox
imay merged pull request #3786: URL: https://github.com/apache/incubator-doris/pull/3786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] imay merged pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

2020-06-05 Thread GitBox
imay merged pull request #3713: URL: https://github.com/apache/incubator-doris/pull/3713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-doris] branch master updated: Use BackendStatus to show BE's infomation in `show backends; ` (#3713)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new a7bf006 Use BackendStatus to show BE's

[incubator-doris] branch master updated: [Bug] Fix a bug that tablet's _preferred_rowset_type may be modified to BETA_ROWSET after cloned (#3750)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 3b6a781 [Bug] Fix a bug that tablet's _

[GitHub] [incubator-doris] imay merged pull request #3750: [Bug] Fix a bug that tablet may be modified to BETA_ROWSET after cloned

2020-06-05 Thread GitBox
imay merged pull request #3750: URL: https://github.com/apache/incubator-doris/pull/3750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] imay closed issue #3783: BE will crash when execute stream load, if bitmap field does not specify BITMAP_UNION type.

2020-06-05 Thread GitBox
imay closed issue #3783: URL: https://github.com/apache/incubator-doris/issues/3783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] imay merged pull request #3768: Disable Bitmap or Hll type in keys or in values with incorrect agg-type

2020-06-05 Thread GitBox
imay merged pull request #3768: URL: https://github.com/apache/incubator-doris/pull/3768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-doris] branch master updated: Disable Bitmap or Hll type in keys or in values with incorrect agg-type (#3768)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new c51f20b Disable Bitmap or Hll type in k

[GitHub] [incubator-doris] imay merged pull request #3784: [Code Refactor] Remove Catalog.getInstance() method

2020-06-05 Thread GitBox
imay merged pull request #3784: URL: https://github.com/apache/incubator-doris/pull/3784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] imay closed issue #3778: [Catalog] Should not use `getInstance()` of Catalog anymore

2020-06-05 Thread GitBox
imay closed issue #3778: URL: https://github.com/apache/incubator-doris/issues/3778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[incubator-doris] branch master updated: Add getValueFn and removeFn to properties (#3782)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 4cbce68 Add getValueFn and removeFn to

[GitHub] [incubator-doris] imay closed issue #3781: [BUG] Show full function not show update_value and remove_fn properties

2020-06-05 Thread GitBox
imay closed issue #3781: URL: https://github.com/apache/incubator-doris/issues/3781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[incubator-doris] branch master updated: [BUG] Fix location url in agg_fn_evaluator (#3780)

2020-06-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0f6e74f [BUG] Fix location url in agg_f

[GitHub] [incubator-doris] imay closed issue #3779: [BUG] Fix _hdfs_location misuse in AggFnEvaluator

2020-06-05 Thread GitBox
imay closed issue #3779: URL: https://github.com/apache/incubator-doris/issues/3779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-doris] imay merged pull request #3780: [BUG] Fix location url in agg_fn_evaluator

2020-06-05 Thread GitBox
imay merged pull request #3780: URL: https://github.com/apache/incubator-doris/pull/3780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] imay merged pull request #3782: Add getValueFn and removeFn to properties

2020-06-05 Thread GitBox
imay merged pull request #3782: URL: https://github.com/apache/incubator-doris/pull/3782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] wyb opened a new issue #3787: [Spark load] Update hive table syntax in loadstmt

2020-06-05 Thread GitBox
wyb opened a new issue #3787: URL: https://github.com/apache/incubator-doris/issues/3787 1. Create an external hive table, including schema, hive db name, hive table name and load required properties (hive.metastore.uris). Implement load from external hive table first, and report an erro

[GitHub] [incubator-doris] morningman commented on pull request #3774: [Doris On ES] [1/3] Add ES QueryBuilders for debug mode

2020-06-05 Thread GitBox
morningman commented on pull request #3774: URL: https://github.com/apache/incubator-doris/pull/3774#issuecomment-639946359 hi @wuyunfeng Plz resolve the conflict. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] marising commented on pull request #3738: [Bug]fix the crash of checksum task #3735

2020-06-05 Thread GitBox
marising commented on pull request #3738: URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-639932459 @morningman Ok,I'll tell you, if our internal review passes. This is an automated message from the Apac

[GitHub] [incubator-doris] morningman closed issue #3776: [Website] CREATE RESOURCE sidebar text and link not right

2020-06-05 Thread GitBox
morningman closed issue #3776: URL: https://github.com/apache/incubator-doris/issues/3776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] kangkaisen commented on issue #3740: [Suggestion] Hope to Add Instructions for BE Configurations

2020-06-05 Thread GitBox
kangkaisen commented on issue #3740: URL: https://github.com/apache/incubator-doris/issues/3740#issuecomment-639570492 > For BE configs, how about to add a new description parameter for config defination like gflag style, for example: > > ``` > CONF_Int32(be_port, "9060", "po

[GitHub] [incubator-doris] morningman commented on pull request #3762: [Memory Engine] MemTablet creation and compatibility handling in BE

2020-06-05 Thread GitBox
morningman commented on pull request #3762: URL: https://github.com/apache/incubator-doris/pull/3762#issuecomment-639558306 Hi @decster , in your comment, you said `When TabletManager::get_tablet is called, only return Tablet, if the underlying tablet is MemTablet, return an error, this ke

[GitHub] [incubator-doris] morningman commented on a change in pull request #3762: [Memory Engine] MemTablet creation and compatibility handling in BE

2020-06-05 Thread GitBox
morningman commented on a change in pull request #3762: URL: https://github.com/apache/incubator-doris/pull/3762#discussion_r435986050 ## File path: be/src/olap/memory/mem_tablet.h ## @@ -27,6 +27,15 @@ class MemSubTablet; class ScanSpec; class MemTabletScan; class WriteTxn;

[GitHub] [incubator-doris] kangkaisen merged pull request #3758: [Doris On ES] Add more detailed error message when fail to create es table

2020-06-05 Thread GitBox
kangkaisen merged pull request #3758: URL: https://github.com/apache/incubator-doris/pull/3758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated (ed9022a -> 5abef19)

2020-06-05 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ed9022a Ignore broken disk when BE starts up (#3741) add 5abef19 [Doris On ES] Add more detailed

[GitHub] [incubator-doris] kangkaisen commented on pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
kangkaisen commented on pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#issuecomment-639550026 > Hi @caiconghui , first of all, this change is worth it. > > But I don't think this is a good way to achieve it. In the previous implementation, it was not a g

[GitHub] [incubator-doris] kangkaisen commented on pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
kangkaisen commented on pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#issuecomment-639547289 I just reviewed a little, and submitted review accidentally. This is an automated message from the A

[GitHub] [incubator-doris] morningman commented on pull request #3738: [Bug]fix the crash of checksum task #3735

2020-06-05 Thread GitBox
morningman commented on pull request #3738: URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-639541105 hi @marising , if you finished this PR, please let me know, thank u. This is an automated message fro

[GitHub] [incubator-doris] morningman opened a new pull request #3786: [Bug] Fix bug that should not use "!=" to judge the equivalence of Type

2020-06-05 Thread GitBox
morningman opened a new pull request #3786: URL: https://github.com/apache/incubator-doris/pull/3786 `org.apache.doris.catalog.Type` is not an enum, so should not judge the equivalence of Type using "==" or "!=" Fix #3785 --

[GitHub] [incubator-doris] morningman opened a new issue #3785: [Bug][Load] Now() function is only support for DATE/DATETIME column

2020-06-05 Thread GitBox
morningman opened a new issue #3785: URL: https://github.com/apache/incubator-doris/issues/3785 **Describe the bug** When using broker like this: ``` LOAD LABEL xxx ... (k1, k2, k3) SET (k4 = now()) ... ``` Even if `k4`'s type is `DATETIME`, this load pr

[GitHub] [incubator-doris] morningman opened a new pull request #3784: [Code Refactor] Remove Catalog.getInstance() method

2020-06-05 Thread GitBox
morningman opened a new pull request #3784: URL: https://github.com/apache/incubator-doris/pull/3784 Use Catalog.getCurrentCatalog() instead, to avoid potential meta operation error. Fix: #3778 This CL does not change any logic. --

[GitHub] [incubator-doris] godcat950081 opened a new issue #3783: BE will crash when execute stream load, if bitmap field does not specify BITMAP_UNION type.

2020-06-05 Thread GitBox
godcat950081 opened a new issue #3783: URL: https://github.com/apache/incubator-doris/issues/3783 BE will crash when execute stream load, if bitmap field does not specify BITMAP_UNION type. Steps to reproduce the behavior: 1. bitmap field does not specify BITMAP_UNION when create

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
caiconghui commented on a change in pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435871389 ## File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java ## @@ -1015,13 +1017,8 @@ private void runOldAlterJob() {

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #3782: Add getValueFn and removeFn to properties

2020-06-05 Thread GitBox
HangyuanLiu opened a new pull request #3782: URL: https://github.com/apache/incubator-doris/pull/3782 Fix #3781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #3781: [BUG] Show full function not show update_value and remove_fn properties

2020-06-05 Thread GitBox
HangyuanLiu opened a new issue #3781: URL: https://github.com/apache/incubator-doris/issues/3781 Show full function not show update_value and remove_fn properties This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
caiconghui commented on a change in pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435865138 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ## @@ -118,30 +118,30 @@ public void processDropMaterializedView(DropMaterial

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
kangkaisen commented on a change in pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435864322 ## File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java ## @@ -1015,13 +1017,8 @@ private void runOldAlterJob() {

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
kangkaisen commented on a change in pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435863730 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ## @@ -169,18 +169,19 @@ public void processAlterTable(AlterTableStmt stmt) th

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

2020-06-05 Thread GitBox
kangkaisen commented on a change in pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435861404 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ## @@ -118,30 +118,30 @@ public void processDropMaterializedView(DropMaterial

[GitHub] [incubator-doris] kangkaisen commented on pull request #3780: [BUG] Fix location url in agg_fn_evaluator

2020-06-05 Thread GitBox
kangkaisen commented on pull request #3780: URL: https://github.com/apache/incubator-doris/pull/3780#issuecomment-639420522 The following code could remove. ``` std::string _hdfs_location; std::string _init_fn_symbol; std::string _update_fn_symbol; std::string

[GitHub] [incubator-doris] imay commented on a change in pull request #3739: [WIP] Support materialized view schema change

2020-06-05 Thread GitBox
imay commented on a change in pull request #3739: URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r435767964 ## File path: be/src/olap/schema_change.cpp ## @@ -266,6 +260,92 @@ bool RowBlockChanger::change_row_block( int32_t ref_column = _schema_map

[GitHub] [incubator-doris] vagetablechicken edited a comment on issue #3469: [Memory Engine] Write Pipeline: internal data processing and storage

2020-06-05 Thread GitBox
vagetablechicken edited a comment on issue #3469: URL: https://github.com/apache/incubator-doris/issues/3469#issuecomment-631289944 ### WAL file format - need to rename e.g.WriteTxnData? WAL file will save multiple partial rows. One write TX's WAL may be split by size => generates multi

[GitHub] [incubator-doris] vagetablechicken commented on issue #3469: [Memory Engine] Write Pipeline: internal data processing and storage

2020-06-05 Thread GitBox
vagetablechicken commented on issue #3469: URL: https://github.com/apache/incubator-doris/issues/3469#issuecomment-639358916 ### Prepare Phase Detail Design Sender BE: ``` Get batch from json_scanner For partialrow in batch: // may missing key cols(partition cols or

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435773614 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,851 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435773402 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -0,0 +1,252 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435773516 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,851 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435772039 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,851 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435769620 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/ColumnParser.java ## @@ -0,0 +1,175 @@ +// Licensed to the Apache Software Foundati

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3729: (#3728) Using SparkDpp to complete some calculation in Spark Load

2020-06-05 Thread GitBox
wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435769378 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/ColumnParser.java ## @@ -0,0 +1,175 @@ +// Licensed to the Apache Software Foundati

[GitHub] [incubator-doris] imay commented on a change in pull request #3677: [WIP] Support materialized view load and insert

2020-06-05 Thread GitBox
imay commented on a change in pull request #3677: URL: https://github.com/apache/incubator-doris/pull/3677#discussion_r435660643 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -453,6 +453,25 @@ private void analyzeSubquery(Analyzer analyzer) thro