kangkaisen commented on pull request #3775: URL: https://github.com/apache/incubator-doris/pull/3775#issuecomment-639550026
> Hi @caiconghui , first of all, this change is worth it. > > But I don't think this is a good way to achieve it. In the previous implementation, it was not a good design to expose the database lock outside, and there have been multiple deadlocks caused by lock nesting problems. > > When the lock granularity is refined to the table level, this way of exposing locks will bring more error-proneness. And so many changes to locks in one PR are difficult to review. > > I suggest to refer to the implementation of kudu [MetadataGroupLock](https://github.com/apache/kudu/blob/master/src/kudu/master/catalog_manager.h) to abstract the operation of the lock and then gradually modify the relevant code. +1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
