[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

caiconghui commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435871389



##########
File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -1015,13 +1017,8 @@ private void runOldAlterJob() {
                 continue;
             }
 
-            db.writeLock();
-            try {
-                OlapTable olapTable = (OlapTable) 
db.getTable(rollupJob.getTableId());
-                rollupJob.cancel(olapTable, "cancelled");
-            } finally {
-                db.writeUnlock();
-            }
+            OlapTable olapTable = (OlapTable) 
db.getTable(rollupJob.getTableId());

Review comment:
       because olap table could be null, so I add write lock in the cancel 
function
     if (olapTable != null) {
               olapTable.writeLock();
               try {
                   Preconditions.checkState(olapTable.getId() == tableId);
                   for (Partition partition : olapTable.getPartitions()) {
                       if (partition.getState() == PartitionState.ROLLUP) {
                           partition.setState(PartitionState.NORMAL);
                       }
                   }
   
                   if (olapTable.getState() == OlapTableState.ROLLUP) {
                       olapTable.setState(OlapTableState.NORMAL);
                   }
               } finally {
                   olapTable.writeUnlock();
               }
           }
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org